Add HAR files for gh_new_issue and gh_new_pr.#17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intro guide!
npm installnpm run har:viewThe clean is a "clean catch" of the URL in question. The gitcasso has our content-script applied.
You can only do the gitcasso if you have a dev server running. The hotreload doesn't seem to work as far as I can tell.(since #20 it now has a button in top-right that triggers a full dev build and refreshes the page)You can also run a unit test against the captured HTML, note in particular
usingHar('gh_pr')gitcasso/browser-extension/tests/lib/enhancers/github.test.ts
Lines 8 to 23 in 59c96f1
npm run har:viewhopefully makes theedit/refreshcycle less painful for graphical fidelityhar:viewrefresh cycle #16