Spotless Maven Plugin fails on Java 25 EA

[scordio]

When executing spotless-maven-plugin:2.44.4:check on Java 25 Build 19, I get the following error:

Execution default of goal com.diffplug.spotless:spotless-maven-plugin:2.44.4:check failed: An API incompatibility was encountered while executing com.diffplug.spotless:spotless-maven-plugin:2.44.4:check: java.lang.NoSuchMethodError: 'java.util.Queue com.sun.tools.javac.util.Log$DeferredDiagnosticHandler.getDiagnostics()'

It seems that DeferredDiagnosticHandler::getDiagnostics is no longer binary compatible as it returns a List<JCDiagnostic> in Java 25 instead of a Queue<JCDiagnostic>.

Full logs at: https://github.com/scordio/jimfs-junit-jupiter/actions/runs/14557109026/job/40835481353

[scordio]

After a closer look at the problem, I realized it's google-java-format failing, not Spotless.

See also google/google-java-format#1247.

Sorry for the noise!

[scordio]

I'm reopening this to signal that an upgrade of google-java-format to at least 1.27.0 is required when running on Java 25:

<googleJavaFormat>
  <version>1.27.0</version>
</googleJavaFormat>

[slachiewicz]

looks like similar issue is also here palantir/palantir-java-format#1305

[SamTV12345]

Now that Java 25 is released this is a real showstopper. It errors on java.lang.NoSuchMethodError: 'java.util.Queue com.sun.tools.javac.util.Log$DeferredDiagnosticHandler.getDiagnostics()'

[slandelle]

@scordio has already explained the workaround above.
The issue is with the default version of <googleJavaFormat> in splotless-maven-plugin 2.46.1.
You just need to force an upgrade, eg

<googleJavaFormat>
  <version>1.28.0</version>
</googleJavaFormat>

An update of the default version has already been committed in #2345 but it hasn't been released yet.

[SamTV12345]

Thanks. That did work. A new release would be awesome. Then I can throw out the manual change.

[R4nmaru314]

having the same issue now with spotless gradle plugin.

fixed it by using googleFormatJson('1.28.0')

[kwin]

The default version of Palantir in https://github.com/diffplug/spotless/blob/main/lib/src/main/java/com/diffplug/spotless/java/PalantirJavaFormatStep.java#L32 needs to be raised to 2.71.0 to fix this issue there as well.

[nedtwigg]

Fix published in plugin-gradle 8.0.0 and plugin-maven 3.0.0.