allow ReplaceRegexStep to function as a Linter, use that to improve RemoveWildcardImports

[iddeepak]

Thank you @Pankraz76. please feel free to use these changes
Original PR: #2557

[Pankraz76]

nice one, thank you so much.

[iddeepak]

Most of the work is already done by @Pankraz76. I updated Lint changes on top of it. kindly request your feedback.
@owaiskazi19
@sbrannen
@nedtwigg

[nedtwigg]

This is close! It needs

• ReplaceRegexStepTest which should be next to this
• right now it can only catch the first problem. but it would be easy to catch all of them
  • in the format function, just return the input unchanged, don't throw
  • in the lint function, return multiple lints

  • spotless/lib/src/main/java/com/diffplug/spotless/FormatterFunc.java

    Lines 28 to 42 in 9cbdac8

    	public interface FormatterFunc {
    	String apply(String input) throws Exception;
    	default String apply(String unix, File file) throws Exception {
    	return apply(unix);
    	}
    	/**
    	* Calculates a list of lints against the given content.
    	* By default, that's just an throwables thrown by the lint.
    	*/
    	default List<Lint> lint(String content, File file) throws Exception {
    	return List.of();
    	}

  • the exception thing is a hack for a formatter which is primarily about formatting. if you are primarily about linting, better to use the other method

[iddeepak]

@nedtwigg
spotless:apply for maven does not show lint errors ? for gradle it does.

[nedtwigg]

aha! you are correct! i will try to fix that problem this week...

[Pankraz76]

is it resolved so we can continue, or is the issue bigger than expected?

[Pankraz76]

undo by inline. Thanks

[iddeepak]

thanks

[iddeepak]

#2455
In maven-plugin too

[Pankraz76]

please let fix this first and have this as second version.

Just fail the build with an bread error like done in open search. The detailed line number can follow afterwards not to block this issue.