fixes #2585: Make spotlessInstallGitPrePushHook task compatible with Gradle configuration cache#2586
Closed
jsoberg wants to merge 2 commits intodiffplug:mainfrom
Closed
Conversation
…with the Gradle configuration cache.
Author
|
Updated changefiles as requested ✔️ lmk if I should be adding anything else, happy to update |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
As described in #2585, the
spotlessInstallGitPrePushHooktask will currently fail when configuration cache is enabled because it attempts to reference the Project during execution time. This PR moves the Project reference (for grabbing root dir) before execution time, following the pattern thatSpotlessDiagnoseTaskand other tasks use.Testing
Ran unit tests, and verified before/after by running the task in https://github.com/meshtastic/Meshtastic-Android with local maven install (failed to run before, succeeded afterward).
PR Follow-ups
After creating the PR, please add a commit that adds a bullet-point under the
[Unreleased]section of CHANGES.md, plugin-gradle/CHANGES.md, and plugin-maven/CHANGES.md which includes:If your change only affects a build plugin, and not the lib, then you only need to update the
plugin-foo/CHANGES.mdfor that plugin.If your change affects lib in an end-user-visible way (fixing a bug, updating a version) then you need to update
CHANGES.mdfor both the lib and all build plugins. Users of a build plugin shouldn't have to refer to lib to see changes that affect them.This makes it easier for the maintainers to quickly release your changes :)