Skip to content

fixes #2585: Make spotlessInstallGitPrePushHook task compatible with Gradle configuration cache#2586

Closed
jsoberg wants to merge 2 commits intodiffplug:mainfrom
jsoberg:jsoberg/#2585/fix-install-git-hooks-task-for-config-cache
Closed

fixes #2585: Make spotlessInstallGitPrePushHook task compatible with Gradle configuration cache#2586
jsoberg wants to merge 2 commits intodiffplug:mainfrom
jsoberg:jsoberg/#2585/fix-install-git-hooks-task-for-config-cache

Conversation

@jsoberg
Copy link
Copy Markdown

@jsoberg jsoberg commented Aug 2, 2025

Overview

As described in #2585, the spotlessInstallGitPrePushHook task will currently fail when configuration cache is enabled because it attempts to reference the Project during execution time. This PR moves the Project reference (for grabbing root dir) before execution time, following the pattern that SpotlessDiagnoseTask and other tasks use.

Testing

Ran unit tests, and verified before/after by running the task in https://github.com/meshtastic/Meshtastic-Android with local maven install (failed to run before, succeeded afterward).

PR Follow-ups

After creating the PR, please add a commit that adds a bullet-point under the [Unreleased] section of CHANGES.md, plugin-gradle/CHANGES.md, and plugin-maven/CHANGES.md which includes:

  • a summary of the change
  • either
    • a link to the issue you are resolving (for small changes)
    • a link to the PR you just created (for big changes likely to have discussion)

If your change only affects a build plugin, and not the lib, then you only need to update the plugin-foo/CHANGES.md for that plugin.

If your change affects lib in an end-user-visible way (fixing a bug, updating a version) then you need to update CHANGES.md for both the lib and all build plugins. Users of a build plugin shouldn't have to refer to lib to see changes that affect them.

This makes it easier for the maintainers to quickly release your changes :)

@jsoberg
Copy link
Copy Markdown
Author

jsoberg commented Aug 2, 2025

Updated changefiles as requested ✔️ lmk if I should be adding anything else, happy to update

@lazer-dev
Copy link
Copy Markdown
Contributor

lazer-dev commented Aug 27, 2025

@jsoberg I have the fix here #2570, your PR is duplication

@nedtwigg nedtwigg closed this Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants