[openrewrite] StringRulesRecipes#2656
Merged
nedtwigg merged 1 commit intodiffplug:mainfrom Oct 1, 2025
Merged
Conversation
Pankraz76
force-pushed
the
pr-fix-CodeCleanup
branch
from
c3a5c9c to
e95bae8
Compare
Pankraz76
changed the title
StringRulesRecipes
Author
|
Caused by: java.io.IOException: Failed to load eclipse groovy formatter: java.lang.IllegalStateException: P2 operation already in progress, close other clients or delete stale lockfile at /home/runner/.m2/repository/dev/equo/p2-data/metadata/.lock |
Member
|
nedtwigg
requested changes
Sep 30, 2025
Member
nedtwigg
left a comment
nedtwigg
left a comment
There was a problem hiding this comment.
at least one of the failures is a real regression, not sure if it's the only one or not
lib/src/main/java/com/diffplug/spotless/java/ImportSorterImpl.java
Outdated
Show resolved
Hide resolved
Pankraz76
force-pushed
the
pr-fix-CodeCleanup
branch
from
e95bae8 to
eb2b071
Compare
Pankraz76
force-pushed
the
pr-fix-CodeCleanup
branch
from
b8b274c to
c12f129
Compare
Pankraz76
force-pushed
the
pr-fix-CodeCleanup
branch
from
c12f129 to
443e6ef
Compare
Merged
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please DO NOT FORCE PUSH. Don't worry about messy history, it's easier to do code review if we can tell what happened after the review, and force pushing breaks that.
Please make sure that your PR allows edits from maintainers. Sometimes it's faster for us to just fix something than it is to describe how to fix it.
After creating the PR, please add a commit that adds a bullet-point under the
[Unreleased]section of CHANGES.md, plugin-gradle/CHANGES.md, and plugin-maven/CHANGES.md which includes:If your change only affects a build plugin, and not the lib, then you only need to update the
plugin-foo/CHANGES.mdfor that plugin.If your change affects lib in an end-user-visible way (fixing a bug, updating a version) then you need to update
CHANGES.mdfor both the lib and all build plugins. Users of a build plugin shouldn't have to refer to lib to see changes that affect them.This makes it easier for the maintainers to quickly release your changes :)