Closed
Conversation
bentatham
force-pushed
the
feature/idea-batches
branch
from
475ba64 to
4acd83c
Compare
nedtwigg
requested changes
Oct 3, 2025
Member
nedtwigg
left a comment
nedtwigg
left a comment
There was a problem hiding this comment.
It would be amazing for the idea formatter to be more usable in Spotless. Thanks for taking a shot at it! Have you tested this locally on a large project and seen a speedup?
Because Spotless does formatting one file at a time, I would not expect this to be much of a speedup unless we broke correctness. But if you have impressive benchmarking results please share them, otherwise I will probably close this approach as unlikely to work.
Comment on lines
+427
to
+429
| void cacheFormattedResult(File originalFile, String formatted) { | ||
| formattedCache.put(originalFile, formatted); | ||
| } |
Member
There was a problem hiding this comment.
unfortunately, I don't think using the File alone is sufficient for a key. The key needs to include the file's content. This is because there are other steps which will operate on the file before or after the idea step.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: this PR heavily relied on copilot to assist.