change show_data to show_observed

Author: cadenmyers13

src/diffpy/srfit/fitbase/fitrecipe.py

@@ -874,7 +874,7 @@ def getBounds2(self):
 
     def plot_recipe(
         self,
-        show_data=True,
+        show_observed=True,
         show_fit=True,
         show_diff=True,
         offset_scale=1.0,
@@ -908,7 +908,7 @@ def plot_recipe(
 
         Parameters
         ----------
-        show_data : bool, optional
+        show_observed : bool, optional
             If True, plot the observed data points. Default is True.
         show_fit : bool, optional
             If True, plot the calculated fit curve. Default is True.
@@ -993,9 +993,9 @@ def plot_recipe(
         >>> axes[0].set_yscale('log')
         >>> plt.savefig('my_fit.png', dpi=300)
         """
-        if not any([show_data, show_fit, show_diff]):
+        if not any([show_observed, show_fit, show_diff]):
             raise ValueError(
-                "At least one of show_data, show_fit, "
+                "At least one of show_observed, show_fit, "
                 "or show_diff must be True"
             )
 
@@ -1036,7 +1036,7 @@ def plot_recipe(
             else:
                 current_ax = ax
                 fig = current_ax.figure
-            if show_data:
+            if show_observed:
                 current_ax.plot(
                     x,
                     yobs,

tests/test_fitrecipe.py

@@ -348,10 +348,10 @@ def test_plot_recipe_bad_display():
     # Case: All plots are disabled
     # expected: raised ValueError with message
     plt.close("all")
-    msg = "At least one of show_data, show_fit, or show_diff must be True"
+    msg = "At least one of show_observed, show_fit, or show_diff must be True"
     with pytest.raises(ValueError, match=msg):
         recipe.plot_recipe(
-            show_data=False,
+            show_observed=False,
             show_diff=False,
             show_fit=False,
         )