Skip to content

Commit 1bdd326

Browse files
committed
chore: modified messages and news file according to feedback
1 parent a2d280a commit 1bdd326

3 files changed

Lines changed: 7 additions & 4 deletions

File tree

news/fix-sasmodels.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
**Changed:**
66

7-
* <news item>
7+
* Temporarily removed support for SAS characteristic functions until we can migrate to the new sasview api.
88

99
**Deprecated:**
1010

@@ -16,7 +16,7 @@
1616

1717
**Fixed:**
1818

19-
* Refactored code utilizing sasmodels to use the new sasview api.
19+
* <news item>
2020

2121
**Security:**
2222

src/diffpy/srfit/pdf/characteristicfunctions.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -416,8 +416,8 @@ def __call__(self, r):
416416
# We also have to make a q-spacing small enough to compute out to at
417417
# least the size of the signal.
418418
raise NotImplementedError(
419-
"As of release 3.2.0, these are not working but we hope to have "
420-
+ "them working again in a future release."
419+
"As of release 3.2.0, SAS characteristic functions are not working"
420+
+ " but we hope to have them working again in a future release."
421421
)
422422

423423
dr = min(0.01, r[1] - r[0])

src/diffpy/srfit/sas/sasparser.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,9 @@ def parseFile(self, filename):
122122
self._banks.append(
123123
[data_obj.x, data_obj.y, data_obj.dx, data_obj.dy]
124124
)
125+
# FIXME: Revisit when we refactor the SAS characteristic functions.
126+
# Why is a list imported but only the first element is taken?
127+
# Is this desired behavior?
125128
self.selectBank(0)
126129
return
127130

0 commit comments

Comments
 (0)