Skip to content

Commit 2649c6d

Browse files
committed
Fix dialogs accessibility
1 parent 63d48ea commit 2649c6d

3 files changed

Lines changed: 16 additions & 0 deletions

File tree

src/plugins/coreplugin/qml/dialogs/EditLoopDialog.qml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,19 +29,25 @@ Dialog {
2929
onClicked: dialog.loopEnabled = checked
3030
}
3131
Label {
32+
id: startPositionLabel
3233
text: qsTr("Start position")
3334
}
3435
MusicTimeSpinBox {
36+
Accessible.labelledBy: startPositionLabel
37+
Accessible.name: startPositionLabel.text
3538
Layout.fillWidth: true
3639
timeline: dialog.timeline
3740
value: dialog.startPosition
3841
to: dialog.endPosition - 1
3942
onValueModified: dialog.startPosition = value
4043
}
4144
Label {
45+
id: endPositionLabel
4246
text: qsTr("End position")
4347
}
4448
MusicTimeSpinBox {
49+
Accessible.labelledBy: endPositionLabel
50+
Accessible.name: endPositionLabel.text
4551
Layout.fillWidth: true
4652
timeline: dialog.timeline
4753
value: dialog.endPosition

src/plugins/coreplugin/qml/dialogs/EditTempoDialog.qml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,12 @@ Dialog {
2323
anchors.fill: parent
2424
columns: 2
2525
Label {
26+
id: tempoLabel
2627
text: qsTr("Tempo")
2728
}
2829
SpinBox {
30+
Accessible.labelledBy: tempoLabel
31+
Accessible.name: tempoLabel.text
2932
Layout.fillWidth: true
3033
readonly property int decimals: 2
3134
from: 10 * Math.pow(10, decimals)
@@ -46,9 +49,12 @@ Dialog {
4649
}
4750
}
4851
Label {
52+
id: positionLabel
4953
text: qsTr("Position")
5054
}
5155
MusicTimeSpinBox {
56+
Accessible.labelledBy: positionLabel
57+
Accessible.name: positionLabel.text
5258
Layout.fillWidth: true
5359
timeline: dialog.timeline
5460
value: dialog.position

src/plugins/coreplugin/qml/dialogs/EditTimeSignatureDialog.qml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ Dialog {
2424
anchors.fill: parent
2525
columns: 2
2626
Label {
27+
id: timeSignatureLabel
2728
text: qsTr("Time signature")
2829
}
2930
RowLayout {
@@ -55,9 +56,12 @@ Dialog {
5556
}
5657
}
5758
Label {
59+
id: positionLabel
5860
text: qsTr("Position")
5961
}
6062
MusicTimeSpinBox {
63+
Accessible.labelledBy: positionLabel
64+
Accessible.name: positionLabel.text
6165
Layout.fillWidth: true
6266
timeline: dialog.timeline
6367
value: dialog.position

0 commit comments

Comments
 (0)