-
Notifications
You must be signed in to change notification settings - Fork 48
chore(www): reduce buildtime #4789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
d860d99
chore(www): reduce buildtime
Barsnes 2c0cebe
chore: reduce buildtime
Barsnes fa74385
optimize more
Barsnes f11c4ae
move biome comment
Barsnes 10553c3
apply code suggestion
Barsnes 5c5c3c9
Update apps/www/app/routes/components/component.tsx
Barsnes 4b4fe8d
dont use sha256
Barsnes 7fa0659
Merge branch 'main' into www/buildtime
Barsnes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,6 +6,17 @@ import remarkGfm from 'remark-gfm'; | |
| import type { TableOfContentsItem, VFile } from './extract-toc'; | ||
| import { extractToc } from './extract-toc'; | ||
|
|
||
| // Cache MDX compilation results by source content to avoid recompiling identical files | ||
| const mdxCache = new Map< | ||
| string, | ||
| { | ||
| code: string; | ||
| // biome-ignore lint/suspicious/noExplicitAny: this is how frontmatter is typed in mdx-bundler | ||
| frontmatter: { [key: string]: any }; | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could use
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is how it's typed in frontmatter, but I guess we could do unkown - should make no difference |
||
| toc: TableOfContentsItem[]; | ||
| } | ||
| >(); | ||
|
|
||
| export const generateFromMdx = async ( | ||
| fileContent: string, | ||
| ): Promise<{ | ||
|
|
@@ -14,6 +25,9 @@ export const generateFromMdx = async ( | |
| frontmatter: { [key: string]: any }; | ||
| toc: TableOfContentsItem[]; | ||
| }> => { | ||
| const cached = mdxCache.get(fileContent); | ||
| if (cached) return cached; | ||
|
|
||
| let tocData: TableOfContentsItem[] = []; | ||
|
|
||
| const result = await bundleMDX({ | ||
|
|
@@ -34,8 +48,10 @@ export const generateFromMdx = async ( | |
| }, | ||
| }); | ||
|
|
||
| return { | ||
| const output = { | ||
| ...result, | ||
| toc: tocData, | ||
| }; | ||
| mdxCache.set(fileContent, output); | ||
| return output; | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.