Skip to content

chore(cli): deprecate cli options for theme#4912

Merged
mimarz merged 9 commits into
mainfrom
chore-add-deprecation-warning-cli
May 27, 2026
Merged

chore(cli): deprecate cli options for theme#4912
mimarz merged 9 commits into
mainfrom
chore-add-deprecation-warning-cli

Conversation

@mimarz
Copy link
Copy Markdown
Collaborator

@mimarz mimarz commented May 20, 2026

resolves #4563

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 20, 2026

🦋 Changeset detected

Latest commit: 26f98c8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@digdir/designsystemet Patch
@digdir/designsystemet-css Patch
@digdir/designsystemet-types Patch
@digdir/designsystemet-react Patch
@digdir/designsystemet-web Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 20, 2026

Preview deployments for this pull request:

storybook - 26. May 2026 - 16:10

@mimarz mimarz requested a review from Copilot May 20, 2026 12:15
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Deprecates token theme-related CLI flags in the @digdir/designsystemet CLI by marking them as deprecated in --help output and adding a runtime warning, steering users toward JSON config as the primary configuration source (per issue #4563).

Changes:

  • Updated tokens create option descriptions to label theme-related flags as deprecated and added --config earlier in the option list.
  • Added a console warning intended to trigger when deprecated theme-related CLI flags are used.
  • Added a changeset documenting the deprecation warning behavior.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
packages/cli/bin/designsystemet.ts Marks theme-related token creation flags as deprecated and adds a runtime deprecation warning.
.changeset/tame-geese-cover.md Releases a patch changeset describing the new deprecation warning.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/cli/bin/designsystemet.ts Outdated
Co-authored-by: Tobias Barsnes <tobias.barsnes@digdir.no>
@mimarz mimarz requested a review from Barsnes May 26, 2026 09:38
@mimarz mimarz marked this pull request as draft May 26, 2026 13:10
@mimarz mimarz marked this pull request as ready for review May 26, 2026 14:27
@mimarz
Copy link
Copy Markdown
Collaborator Author

mimarz commented May 26, 2026

ready for review again @Barsnes found a small edge-case with false positives and defaults.

@mimarz mimarz merged commit 2fcf39c into main May 27, 2026
24 checks passed
@mimarz mimarz deleted the chore-add-deprecation-warning-cli branch May 27, 2026 07:25
@github-actions github-actions Bot mentioned this pull request May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecate cli theme options

3 participants