feat(map): GeoJSON overlay, cross-project map mgmt, download history (#129) - #157
Closed
luandro wants to merge 3 commits into
Closed
feat(map): GeoJSON overlay, cross-project map mgmt, download history (#129)#157luandro wants to merge 3 commits into
luandro wants to merge 3 commits into
Conversation
luandro
added
the
agent:implementation-in-progress
…Overlay Add unit tests for the two new components to satisfy the 80% global branch coverage gate before push. - DownloadHistory.test.tsx: error row + retry, loading skeleton, empty state, ready/error status labels, size formatting (8 tests). - GeoJsonOverlay.test.tsx: dropzone render, drag-active hint, FeatureCollection / single Feature / bare Geometry acceptance, invalid GeoJSON / bad extension / unparseable JSON rejection, large-file warning, visibility toggle, remove and clear-all (12 tests). Both files pass and exceed 80% lines/branch/functions/statements.
- Idle dropzone was absolute inset-0 z-20 with no pointer-events-none, covering the MapLibre canvas and swallowing pan/zoom/draw events. Now pointer-events-none when idle, pointer-events-auto only during drag. - Remove unused overlaysRef (written, never read). - Remove unused GeoJsonData export and overlayHidden message (never rendered), keeping en/es/pt i18n in sync.
luandro
force-pushed
the
agent/comapeo-cloud-app/issue-129
branch
from
July 28, 2026 04:32
e02a3ec to
3b2373f
Compare
Contributor
|
Preview deployment ready: https://agent-comapeo-cloud-app-issu-lj19.comapeo-cloud-app.pages.dev Commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft — needs rebase before merge
Phase 1 "Should Have" follow-ups for #129. This draft captures the two test files that
were the final blocker for CI (DownloadHistory + GeoJsonOverlay coverage), which now pass
the full Husky
validategate locally and on push:tests/unit/screens/MapScreen/DownloadHistory.test.tsxtests/unit/screens/MapScreen/GeoJsonOverlay.test.tsxVerification (this push,
e02a3ec)InviteScreenwarning only)All files | 87.55 | 80.42 | 86.5 | 89.26(branch 80.42% > 80% gate)check:i18n: greenThe branch forked from an older
main; its committedsrc/i18n/messages/en.jsonis ~183lines behind
origin/main(main addedcategories.*and other keys after the split).Husky only compares the working tree against the branch's own committed
en.json, so itpassed — but a squash-merge onto current
mainwould drop those newer keys. Pleaserebase onto
origin/main(or let me do it) and re-run the gate before merging.Scope note
The WIP feature code in
32aca2eis in-progress per labelagent:implementation-in-progress.This PR is opened as DRAFT so the test coverage gate is satisfied and CI is green; the
feature itself is not yet review-complete.
Closes #129