feat(data): full-screen map view + shared MapScreenLayout component (#132)

[luandro]

Summary

Closes #132. Two related changes to the Data screen map experience:

1. Map view is now the default. src/stores/view-mode-store.ts default viewMode changed from 'grid' to 'map', so the Data screen opens in the full-screen map when a project has observations.
2. Extracted a shared MapScreenLayout component. The full-screen map shell (map canvas + overlay slots for top/bottom-left/right controls + a desktop sidebar) is now src/components/shared/MapScreenLayout/ so other screens can reuse it instead of re-implementing the same overlay pattern.

DataScreen.tsx now early-returns a full-screen ObservationsMap (passed as children to MapScreenLayout, which is a pure overlay shell — no nested MapContainer) with overlay controls when viewMode === 'map':

• topLeft — desktop ObservationFilterBar (hidden md:block, mirroring the grid branch)
• topRight — grid-view toggle
• bottomLeft — Filters button (mobile only, opens a FilterSheet)
• bottomRight — export observations button

The map branch renders regardless of observation count / pending state, so the map shows its own empty/loading overlay (no grid-chrome flash on cold load, no dead toggle when empty).

Changes

• src/stores/view-mode-store.ts — default viewMode: 'map'.
• src/components/shared/MapScreenLayout/ — new shared full-screen map layout shell (MapScreenLayout.tsx + index.ts + .stories.tsx + .test.tsx). Pure overlay: renders children + topLeft/topRight/bottomLeft/bottomRight/sidebar slots; sidebar is desktop-gated. No internal MapContainer.
• src/screens/DataScreen.tsx — early-return full-screen map branch (renders even when empty/pending); grid branch untouched.
• tests/unit/components/shared/MapScreenLayout/MapScreenLayout.test.tsx — 11 new tests for the shared component (slots, mobile/desktop sidebar).
• tests/unit/screens/DataScreen.test.tsx — updated for the new map default + added map-view / grid-toggle tests (29 tests).
• tests/e2e/critical-flows.e2e.ts — seeds view-mode-preference to grid in Flows 1 & 2 so the grid-asserting e2e specs keep passing now that the default is the map (fresh contexts rehydrate to map).

Verification

Local gates run independently (not trusting harness self-report):

• npx tsc --noEmit — clean
• npx vitest run (MapScreenLayout 11 + DataScreen 29) — 40/40 pass
• npx eslint <changed> — clean
• npx prettier --check <changed> — clean
• npm run extract-messages — no en.json drift (no new i18n keys needed)
• Husky pre-push npm run validate (lint + coverage + build + i18n) — Full Validation PASSED on push

Kimi K3 read-only review (loop-closed): VERDICT: PASS. All findings resolved across two review rounds:

• B1 — e2e grid-default break → fixed (seed view-mode-preference); Kimi re-ran the patched Playwright critical-flows suite: 7/7 passed.
• P1 — no desktop filters in default map view → fixed (topLeft ObservationFilterBar); then the mobile-stacking regression from that fix was itself fixed (hidden md:block wrap).
• P2 — dead "switch to map" toggle when empty → fixed (map branch no longer gates on observations.length > 0).
• P3 — grid-chrome flash on cold load → fixed (early return to map branch; synchronous persist rehydrate).

Remaining notes

• Branch is 1 commit ahead of origin/main, not behind; no en.json clobber risk.
• Non-blocking, out-of-scope: mobile-data-observations light/dark screenshot specs fail at HEAD on main too (stale getByRole('tab') locator from feat: #72 — Replace Data nav icon with map marker; extract Alerts into dedicated screen #108) — tracked separately.
• MapScreenLayout nits (duplicate stories, tautological test assertion) noted by review as non-blocking; left as-is to keep the diff focused.

🤖 Generated with Hermes Agent

[github-actions]

Preview deployment ready: https://agent-comapeo-cloud-app-issu-vugq.comapeo-cloud-app.pages.dev

Commit: 2ce8875

[luandro]

We are missing on the data map view a layers button which should be placed right beneath the list button on the top right. The user should be able to easily change in between map layers to facilitate navigation.