Skip to content

feat(data): full-screen map view + shared MapScreenLayout component (#132) - #158

Merged
luandro merged 7 commits into
mainfrom
agent/comapeo-cloud-app/issue-132
Aug 1, 2026
Merged

feat(data): full-screen map view + shared MapScreenLayout component (#132)#158
luandro merged 7 commits into
mainfrom
agent/comapeo-cloud-app/issue-132

Conversation

@luandro

@luandro luandro commented Jul 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

Closes #132.

  • Makes the Data screen map view the default and extracts the reusable MapScreenLayout shell.
  • Adds the map-layer switcher directly below the grid/list toggle and hides sorting in map view on both desktop and mobile, addressing the review comment.
  • Hardens map loading/error/empty states, responsive control spacing, control stacking, attribution access, and the grid-view escape path.
  • Removes duplicate stories/baselines and strengthens unit and browser regression coverage.

Review comment addressed

  • The layers button is available beneath the top-right view toggle with an 8 px gap.
  • The ordering control is hidden everywhere it is meaningless in map view.
  • Responsive checks cover 768, 1024, and 1180 px, including real layer-menu and attribution interactions.

Verification

Local checks:

  • 109 focused unit tests passed across MapContainer, MapScreenLayout, ObservationFilterBar, ObservationsMap, and DataScreen.
  • 10/10 critical Chromium E2E flows passed with retries disabled; the final responsive attribution check passed independently at all three target widths.
  • TypeScript, ESLint, Prettier, git diff --check, npm run build:ci, and npm run check:i18n are clean.
  • The working tree is clean; the branch is 7 commits ahead of and 0 behind main.

GitHub CI run 794 completed successfully, including audit, lint, typecheck, unit/i18n, secret scan, Storybook tests, visual-regression check, build/E2E, preview deployment, and preview smoke/E2E.

Independent review loops

  • CodexPro PR Merge-Readiness Review: blockers none; pre-merge fixes none; post-merge issues none.
  • Opus 5 max-effort review: blockers none; pre-merge fixes none; post-merge issues none.
  • Every finding raised in earlier rounds was fixed, re-tested, pushed, and re-reviewed.

Ready for human review and merge.

@github-actions

github-actions Bot commented Jul 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Preview deployment ready: https://agent-comapeo-cloud-app-issu-vugq.comapeo-cloud-app.pages.dev

Commit: c194167

@luandro
chore(visual-regression): add MapScreenLayout baseline screenshots
4f428f1 
New component introduced in #132 ships 5 Storybook stories
(default, non-interactive, with-bottom-buttons, with-sidebar,
with-top-right) at both desktop and mobile viewports. These had
no committed baseline, so the visual-regression-check reported
5 added and failed CI. Add the generated baselines so the check
passes. Pre-existing baseline PNGs were intentionally left
untouched (their drift was tooling noise, not code change).
@luandro

luandro commented Jul 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

We are missing on the data map view a layers button which should be placed right beneath the list button on the top right. The user should be able to easily change in between map layers to facilitate navigation.

The ordering control makes no sense on the map view, should be hidden.

@luandro
luandro marked this pull request as ready for review August 1, 2026 13:17
@luandro

luandro commented Aug 1, 2026

Copy link
Copy Markdown
Contributor Author

Ready for human merge.

  • The requested layers control is directly below the grid/list toggle, and sorting is hidden in map view on desktop and mobile.
  • CodexPro Merge-Readiness Review final verdict: blockers none, pre-merge fixes none, post-merge issues none.
  • Opus 5 max-effort final verdict: blockers none, pre-merge fixes none, post-merge issues none.
  • GitHub CI run 794 completed successfully, including unit, typecheck, lint, audit, Storybook, visual-regression check, build/E2E, and preview E2E/smoke gates.
  • Local verification is clean: 109 focused unit tests, 10/10 critical Chromium flows with retries disabled, TypeScript, ESLint, Prettier, build, i18n, and diff checks.
  • Head dd01a2a is mergeable and 0 commits behind main.

All PR-scoped findings are closed. Please perform the human merge when ready.

@luandro
luandro merged commit ae60e4d into main Aug 1, 2026
21 checks passed
@luandro
luandro deleted the agent/comapeo-cloud-app/issue-132 branch August 1, 2026 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat(data): Full-screen map view layout + shared MapScreenLayout component

1 participant

@luandro