fix(invite): wrap long invite codes instead of truncating (#155) - #160
Draft
luandro wants to merge 3 commits into
Draft
fix(invite): wrap long invite codes instead of truncating (#155)#160luandro wants to merge 3 commits into
luandro wants to merge 3 commits into
Conversation
Replace truncate with break-words + overflow-wrap-anywhere on invite URL and invite code <code> elements to prevent horizontal scrolling on mobile when invite codes are long unbreakable base64url strings.
luandro
added
the
agent:ready-for-review
Contributor
|
Preview deployment ready: https://agent-comapeo-cloud-app-issu-j3oa.comapeo-cloud-app.pages.dev Commit: |
…e wrapping (#155) - Add InviteGenerated story to SettingsScreen stories that fills form with long URL + token, submits, and asserts wrapped invite code display - Update mock to return long encrypted invite code by default - Add desktop + mobile baseline screenshots verifying wrapping fix
…orybook findByText - MINOR: Replace dead class overflow-wrap-anywhere with wrap-anywhere (real Tailwind v4 utility) - storybook: Scope InviteGenerated findByText to invite-code row to avoid matching the URL code element (both contain mock-encrypted-code- pattern) - Update test assertions from overflow-wrap-anywhere to wrap-anywhere
Contributor
Author
|
This pull request should be updated to truncate every component on the application. For example data tags are also overflowing and also need to be truncated. Make sure to check every component that has the potential it's overflow, and make it truncated so we don't have the overflow issue anywhere. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #155
Replaces
truncatewithbreak-words overflow-wrap-anywhere min-w-0on invite-code<code>elements in InviteScreen, preventing overflow on long codes. Adds 2 wrapping unit tests.Kimi review: READY (0 blockers, 0 major, 1 minor, 3 nits).