fix: a11y violations in toast/button/screen stories (#163) - #168
Open
luandro wants to merge 3 commits into
Open
Conversation
- Wrap toast stories in <main> landmark for a11y - Use navy #04145C for toast trigger buttons (color-contrast fix) - Add bg-navy border-navy to Button Primary story (color-contrast fix) - Wrap DataScreen story in ToastProvider + <main> (fixes useToast crash) - Add <main> decorator to SettingsScreen story (a11y landmark) Resolves #163
Contributor
|
Preview deployment ready: https://agent-comapeo-cloud-app-issu-97kh.comapeo-cloud-app.pages.dev Commit: |
…anges The a11y contrast fixes in the toast and Data screen stories intentionally change their rendered appearance, so the mobile Storybook screenshot baseline diverged from CI and the visual-regression-check failed. Regenerate the affected baseline images from CI's own renders (the 8 mobile stories that exceed the 1% pixel threshold) so the check matches: - components-toast: error/info/stacked/success/with-description - screens-data: error-state/with-project-and-data/with-project-desktop No threshold changes and no test skips — the visual changes are real and the baseline is brought back in sync with them. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a11y violations in Storybook stories:
All 135 storybook tests pass, coverage at 87.66%.