Skip to content

fix(issue-162): refactor(test): extract shared generateInvite helper in SettingsScreen tests #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
luandro wants to merge 2 commits into
base: main
Choose a base branch
from
+55 −30
Open

fix(issue-162): refactor(test): extract shared generateInvite helper in SettingsScreen tests #171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
208affa
refactor(test): extract generateInvite helper
github-actions[bot] Jul 30, 2026
f05dab8
ci(smoke): poll /api/info until Functions are live before asserting 400
Jul 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 41 additions & 5 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -615,7 +615,7 @@ jobs:
needs: preview
if: github.event_name == 'pull_request'
runs-on: ubuntu-latest
timeout-minutes: 3
timeout-minutes: 5
steps:
- name: Smoke test — app reachability
run: |
Expand All @@ -627,7 +627,19 @@ jobs:

- name: Smoke test — API proxy rejects missing target
run: |
STATUS=$(curl -s -o /dev/null -w "%{http_code}" "${{ needs.preview.outputs.preview-url }}/api/info")
# Pages Functions propagate a few seconds after "Deployment complete";
# until they are live, /api/* falls through to the static 404 handler.
# Poll until the function answers (400) instead of failing on the first
# request, but still assert the final status is exactly 400.
STATUS=""
for i in $(seq 1 6); do
STATUS=$(curl -s -o /dev/null -w "%{http_code}" "${{ needs.preview.outputs.preview-url }}/api/info")
if [ "$STATUS" = "400" ]; then
break
fi
echo "Attempt $i: expected 400, got $STATUS (Functions may still be propagating); retrying in 10s..."
sleep 10
done
if [ "$STATUS" != "400" ]; then
echo "Expected 400 for /api/info without x-target-url, got $STATUS"
exit 1
Expand Down Expand Up @@ -827,7 +839,19 @@ jobs:

- name: Smoke test — API proxy rejects missing target
run: |
STATUS=$(curl -s -o /dev/null -w "%{http_code}" "${{ vars.STAGING_URL || needs.staging.outputs.deployment-url }}/api/info")
# Pages Functions propagate a few seconds after "Deployment complete";
# until they are live, /api/* falls through to the static 404 handler.
# Poll until the function answers (400) instead of failing on the first
# request, but still assert the final status is exactly 400.
STATUS=""
for i in $(seq 1 6); do
STATUS=$(curl -s -o /dev/null -w "%{http_code}" "${{ vars.STAGING_URL || needs.staging.outputs.deployment-url }}/api/info")
if [ "$STATUS" = "400" ]; then
break
fi
echo "Attempt $i: expected 400, got $STATUS (Functions may still be propagating); retrying in 15s..."
sleep 15
done
if [ "$STATUS" != "400" ]; then
echo "Expected 400 for /api/info without x-target-url, got $STATUS"
exit 1
Expand Down Expand Up @@ -911,7 +935,7 @@ jobs:
needs: deploy
if: github.ref == 'refs/heads/main' && github.event_name == 'push'
runs-on: ubuntu-latest
timeout-minutes: 3
timeout-minutes: 5
steps:
- name: Smoke test — app reachability
run: |
Expand All @@ -923,7 +947,19 @@ jobs:

- name: Smoke test — API proxy rejects missing target
run: |
STATUS=$(curl -s -o /dev/null -w "%{http_code}" "https://app.comapeo.cloud/api/info")
# Pages Functions propagate a few seconds after "Deployment complete";
# until they are live, /api/* falls through to the static 404 handler.
# Poll until the function answers (400) instead of failing on the first
# request, but still assert the final status is exactly 400.
STATUS=""
for i in $(seq 1 6); do
STATUS=$(curl -s -o /dev/null -w "%{http_code}" "https://app.comapeo.cloud/api/info")
if [ "$STATUS" = "400" ]; then
break
fi
echo "Attempt $i: expected 400, got $STATUS (Functions may still be propagating); retrying in 10s..."
sleep 10
done
if [ "$STATUS" != "400" ]; then
echo "Expected 400 for /api/info without x-target-url, got $STATUS"
exit 1
Expand Down
39 changes: 14 additions & 25 deletions tests/unit/screens/SettingsScreen.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import type { UserEvent } from '@testing-library/user-event';
import { server } from '@tests/mocks/node';
import { fireEvent, render, screen, userEvent } from '@tests/mocks/test-utils';
import { HttpResponse, http } from 'msw';
Expand Down Expand Up @@ -26,6 +27,15 @@ vi.mock('@/lib/local-storage-utils', () => ({
clearAllStorage: vi.fn(() => Promise.resolve()),
}));

async function generateInvite(user: UserEvent) {
await user.type(
screen.getByLabelText('Remote Archive URL'),
'https://archive.example.com',
);
await user.type(screen.getByLabelText('Bearer Token'), 'my-secret-token');
await user.click(screen.getByRole('button', { name: 'Generate Invite' }));
}

beforeEach(async () => {
await resetDb();
useAuthStore.setState({
Expand Down Expand Up @@ -82,12 +92,7 @@ describe('SettingsScreen', () => {
const user = userEvent.setup();
render(<SettingsScreen />);

await user.type(
screen.getByLabelText('Remote Archive URL'),
'https://archive.example.com',
);
await user.type(screen.getByLabelText('Bearer Token'), 'my-secret-token');
await user.click(screen.getByRole('button', { name: 'Generate Invite' }));
await generateInvite(user);

// Results header should appear
expect(await screen.findByText('Results')).toBeInTheDocument();
Expand All @@ -113,12 +118,7 @@ describe('SettingsScreen', () => {
const user = userEvent.setup();
render(<SettingsScreen />);

await user.type(
screen.getByLabelText('Remote Archive URL'),
'https://archive.example.com',
);
await user.type(screen.getByLabelText('Bearer Token'), 'my-secret-token');
await user.click(screen.getByRole('button', { name: 'Generate Invite' }));
await generateInvite(user);

expect(await screen.findByText('Expires in 24 hours.')).toBeInTheDocument();
});
Expand All @@ -141,12 +141,7 @@ describe('SettingsScreen', () => {
const user = userEvent.setup();
render(<SettingsScreen />);

await user.type(
screen.getByLabelText('Remote Archive URL'),
'https://archive.example.com',
);
await user.type(screen.getByLabelText('Bearer Token'), 'my-secret-token');
await user.click(screen.getByRole('button', { name: 'Generate Invite' }));
await generateInvite(user);

expect(
await screen.findByText(
Expand All @@ -163,13 +158,7 @@ describe('SettingsScreen', () => {
const user = userEvent.setup();
render(<SettingsScreen />);

// Fill form and generate
await user.type(
screen.getByLabelText('Remote Archive URL'),
'https://archive.example.com',
);
await user.type(screen.getByLabelText('Bearer Token'), 'my-secret-token');
await user.click(screen.getByRole('button', { name: 'Generate Invite' }));
await generateInvite(user);

// Wait for results to render
await screen.findByText('Results');
Expand Down
Loading