Feat/manager close - #1137
Merged
Merged
Conversation
Member
|
I see the tests are failing right now. Is this ready for review? Do you want help resolving failing tests? |
Contributor
Author
|
Help resolving would be appreciated. At least just seeing if there are obvious flaws. I think something relating to fastify init might be off? |
Contributor
Author
|
Issue was to do with a race condition inside fastify somewhere. The server wasn't listening so the close call wasn't working. Calling close on the underlying server fixed it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes sure the manager is being cleaned up after every test. Main use is to also clean up the worker processes in the indexer worker PR.
This also updates the tests to make sure we're using the util for creating / tearing down managers.
Part of #1092