fix: NO_ROLE should not sync config core - #1143
Merged
Merged
Conversation
gmaclennan
approved these changes
Oct 15, 2025
gmaclennan
left a comment
gmaclennan
left a comment
Member
There was a problem hiding this comment.
ok, good, looks like this passes. I probably added this making incorrect assumptions that it's needed, and it will be better (more secure) with this change
This was referenced Oct 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per this comment: #1138 (comment)
NO_ROLE should not include the config core in case the user's final resolved role doesn't have it.
This might lead to bugs relating to deviceInfo needing to be present, but we'll see in the tests.