Skip to content

fix: allow PUT method for preflight requests #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
achou11 merged 4 commits into from
Apr 13, 2026
Merged

fix: allow PUT method for preflight requests #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b1774c9
update tests
achou11 Apr 9, 2026
3a81975
include PUT in preflight cors header
achou11 Apr 9, 2026
9864937
formatting fix for affected file
achou11 Apr 9, 2026
f351ddf
Merge branch 'main' into 45/cors-preflight-include-put
achou11 Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/routes/root.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ const DOWNLOADS_BASE = '/downloads/'

const { preflight } = cors({
origin: '*',
allowMethods: ['GET', 'POST', 'DELETE', 'OPTIONS'],
allowMethods: ['GET', 'POST', 'DELETE', 'OPTIONS', 'PUT'],
allowHeaders: ['Content-Type'],
})

Expand All @@ -25,7 +25,10 @@ const { preflight } = cors({
*/
function corsify(response: Response): Response {
// Skip if CORS headers already present or if it's a WebSocket upgrade
if (response.headers.get('access-control-allow-origin') || response.status === 101) {
if (
response.headers.get('access-control-allow-origin') ||
response.status === 101
) {
return response
}
// Create new headers with CORS header added
Expand Down
6 changes: 3 additions & 3 deletions test/cors.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ describe('CORS Headers', () => {
expect(response.status).toBe(204)
expect(response.headers.get('access-control-allow-origin')).toBe('*')
expect(response.headers.get('access-control-allow-methods')).toBe(
'GET,POST,DELETE,OPTIONS',
'GET,POST,DELETE,OPTIONS,PUT',
)
expect(response.headers.get('access-control-allow-headers')).toBe(
'Content-Type',
Expand All @@ -51,7 +51,7 @@ describe('CORS Headers', () => {
expect(response.status).toBe(204)
expect(response.headers.get('access-control-allow-origin')).toBe('*')
expect(response.headers.get('access-control-allow-methods')).toBe(
'GET,POST,DELETE,OPTIONS',
'GET,POST,DELETE,OPTIONS,PUT',
)
})

Expand All @@ -63,7 +63,7 @@ describe('CORS Headers', () => {
expect(response.status).toBe(204)
expect(response.headers.get('access-control-allow-origin')).toBe('*')
expect(response.headers.get('access-control-allow-methods')).toBe(
'GET,POST,DELETE,OPTIONS',
'GET,POST,DELETE,OPTIONS,PUT',
)
})

Expand Down
Loading