fix: address breaking change from typebox patch release - #58
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
| }, | ||
| "stubs/empty-fetch": { | ||
| "extraneous": true | ||
| }, | ||
| "stubs/empty-fetch-stub": { | ||
| "version": "1.0.0", | ||
| "extraneous": true |
There was a problem hiding this comment.
got this diff when running npm install - maybe due to different npm versions locally? can revert if preferred
achou11
changed the title
- Upgrades Electron to 42 - Upgrades development Node version to 24.17.0 - Using Node >=24.16.0 causes a transitive dep for `@electron/packager` to break, requiring an override (see e0565af). Apparently, Node [24.18.0](https://nodejs.org/en/blog/release/v24.18.0) fixes the issue but the relevant electron upstream projects are replacing the dep anyways. - Update in transitive dep causes a runtime error from `@comapeo/map-server` to occur. For now, we specify an override for the offending transitive dep (see digidem/comapeo-map-server#58) - Sentry configuration is updated to move away from deprecated APIs in Sentry core (see c3a08da)
|
It seems like this change was reverted (see sinclairzx81/typebox#1582 (comment)), but the same comment also references breaking changes in minor releases (with semver coming in 2.x), so can you change the dep to |
Done in d5f8d93 |
2 participants
Seems like
ReadonlyTypewas renamed toReadonlyObjectin 1.1.28. Our semver range includes this version, causing any consuming app that may update their lockfile to pull in these changes and result in runtime errors.Wondering if we should consider tightening the semver range in this case. Not sure what typebox's release behavior generally is.