chore: fix publint failure in release workflow - #62
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Member
Author
|
Maybe just opting to run |
gmaclennan
reviewed
Jul 22, 2026
gmaclennan
left a comment
Member
There was a problem hiding this comment.
I don't think the postpack is needed? The CI check ensures we don't release with it broken. This is all we can do until publint fixes things.
Member
Author
Addressed via 7ba0103 (also updated PR description) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue seen here where running publint during
npm pack --dry-runfails on npm v12. The release action we use uses npm v12 and runs the dry run internally which is how this error surfaces.There might be an fix in publint but it's currently not released (link).
I've opted for not running publint as part of the
testscripts and instead having it be its own script that runs as a dedicated script in CI. Also no longer runs as part of the release workflow build command.