Fix uncaught JSON.parse exception in handleResponse#93
Open
prjanitor wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
handleResponsefunction callsJSON.parse(text)without a try-catch block. If the server returns malformed JSON (e.g., HTML error page, plain text),JSON.parsethrows aSyntaxErrorthat is not caught, causing the promise to reject with an unhandled exception.Solution
Wrap the
JSON.parsecall in a try-catch block to gracefully handle malformed JSON responses. When parsing fails,datais set tonull, allowing the existing error handling logic to continue functioning correctly.Changes
handleResponseinsrc/fetchWrapper/fetchWrapper.tsJSON.parse(text)calldatais set tonullinstead of throwing an uncaught exceptionThis PR was generated by PRJanitor — an automated tool that finds and fixes small bugs in open-source projects.
We respect your contribution guidelines — if your project doesn't accept bot PRs, we won't send more. You can also add a
.github/prjanitor.ymlfile withenabled: falseto opt out explicitly.