Fix 'Filter by value' top/bottom n returning more items than requested#607
Open
mvanhorn wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The column filter's top-N / bottom-N mode now caps the output at N ranked values without overcounting when the filtered column has duplicate values, while still returning the rows that belong to the top (or bottom) N distinct values.
Why this matters
The previous logic could yield more than N rows when the Nth-ranked value appeared multiple times, so a "top 10" filter could pass through many more than ten items. Capping per ranked value keeps the result bounded to the intended N distinct values across duplicates. Reported in #541.
Testing
Verified the filter against inputs with duplicate values in the ranked column so the cap holds without dropping rows that share a top-ranked value.
Closes #541