remove node ready state requirement

The LB health checks will take care of this.

Author: gottwald

cloud-controller-manager/do/loadbalancers.go

@@ -35,7 +35,6 @@ import (
 	cloudprovider "k8s.io/cloud-provider"
 	"k8s.io/cloud-provider/api"
 	servicehelpers "k8s.io/cloud-provider/service/helpers"
-	nodeutil "k8s.io/component-helpers/node/util"
 	"k8s.io/klog/v2"
 	utilnet "k8s.io/utils/net"
 
@@ -532,6 +531,7 @@ const (
 
 // nodeState contains the classification and filtering results for nodes
 type nodeState struct {
+	// readyNodes are nodes that are ready to serve as LB backends
 	readyNodes         []*v1.Node
 	filteredCount      int
 	singleStackV4Nodes []*v1.Node
@@ -570,11 +570,11 @@ func (ns *nodeState) isAllDualStack() bool {
 	return ns.hasDualStackNodes() && !ns.hasSingleStackV4()
 }
 
-// filterAndClassifyNodes filters nodes by readiness and (for EXTERNAL LBs) external IPs,
-// then classifies remaining nodes as singleStackV4, singleStackV6, or dualStack.
+// filterAndClassifyNodes filters nodes by available IP stacks and differentiates between
+// singleStackV4, singleStackV6, or dualStack.
 //
-// For INTERNAL load balancers, only Ready status is checked (public IPs not required).
-// For EXTERNAL load balancers, nodes must be Ready, have at least one external IP,
+// For INTERNAL load balancers, public IPs not required, private assumed.
+// For EXTERNAL load balancers, have at least one external IP,
 // and singleStackV6 nodes are filtered out (not supported for external connectivity).
 func filterAndClassifyNodes(nodes []*v1.Node, isInternalLB bool) *nodeState {
 	state := &nodeState{
@@ -585,20 +585,14 @@ func filterAndClassifyNodes(nodes []*v1.Node, isInternalLB bool) *nodeState {
 	}
 
 	for _, node := range nodes {
-		// Filter 1: Check NodeReady condition (applies to ALL LB types)
-		if !isNodeReady(node) {
-			klog.V(4).Infof("Node %s filtered: not in Ready state", node.Name)
-			state.filteredCount++
-			continue
-		}
-
-		// For INTERNAL LBs, Ready is sufficient - no need for public IPs
+		// For INTERNAL LBs, no need for public IPs - assuming ready
+		// this is just here so that we can expand in the future when internalLBs support v6 or other features.
 		if isInternalLB {
 			state.readyNodes = append(state.readyNodes, node)
 			continue
 		}
 
-		// Filter 2: For EXTERNAL LBs, check for external IPs and classify
+		// For EXTERNAL LBs, check for external IPs and classify
 		classification := classifyNode(node)
 
 		if classification == nodeClassPublicNetUnready {
@@ -629,12 +623,6 @@ func filterAndClassifyNodes(nodes []*v1.Node, isInternalLB bool) *nodeState {
 	return state
 }
 
-// isNodeReady checks if node has Ready condition = True
-func isNodeReady(node *v1.Node) bool {
-	_, condition := nodeutil.GetNodeCondition(&node.Status, v1.NodeReady)
-	return condition != nil && condition.Status == v1.ConditionTrue
-}
-
 // classifyNode determines node's IP stack classification
 func classifyNode(node *v1.Node) nodeClassification {
 	hasIPv4 := false
@@ -938,10 +926,10 @@ func (l *loadBalancers) buildLoadBalancerRequest(ctx context.Context, service *v
 	// Log filtering results
 	if nodeState.filteredCount > 0 {
 		if isInternalLB {
-			klog.V(2).Infof("Service %s/%s: Filtered out %d non-ready nodes, %d ready nodes remaining (INTERNAL LB)",
+			klog.V(2).Infof("Service %s/%s: Filtered out %d non-lb-ready nodes, %d lb-ready nodes remaining (INTERNAL LB)",
 				service.Namespace, service.Name, nodeState.filteredCount, len(nodeState.readyNodes))
 		} else {
-			klog.V(2).Infof("Service %s/%s: Filtered out %d non-ready/non-public nodes, %d ready nodes remaining (%d dualStack, %d singleStackV4)",
+			klog.V(2).Infof("Service %s/%s: Filtered out %d non-lb-ready/non-public nodes, %d lb-ready nodes remaining (%d dualStack, %d singleStackV4)",
 				service.Namespace, service.Name, nodeState.filteredCount,
 				len(nodeState.readyNodes), len(nodeState.dualStackNodes), len(nodeState.singleStackV4Nodes))
 

cloud-controller-manager/do/loadbalancers_test.go

@@ -6857,18 +6857,6 @@ func TestFilterAndClassifyNodes_ExternalLB(t *testing.T) {
 			expectedSingleStackV4: []string{"node2"},
 			expectedDualStack:     []string{"node1"},
 		},
-		{
-			name: "not ready nodes filtered",
-			nodes: []*v1.Node{
-				newNodeWithIPs("node1", "10.0.0.1", "2001:db8::1", true),
-				newNodeWithIPs("node2", "10.0.0.2", "2001:db8::2", false),
-			},
-			isInternalLB:          false,
-			expectedReadyCount:    1,
-			expectedFilteredCount: 1,
-			expectedAllDualStack:  true,
-			expectedDualStack:     []string{"node1"},
-		},
 		{
 			name: "nodes without external IPs filtered",
 			nodes: []*v1.Node{
@@ -6948,15 +6936,6 @@ func TestFilterAndClassifyNodes_InternalLB(t *testing.T) {
 			expectedReadyCount:    2,
 			expectedFilteredCount: 0,
 		},
-		{
-			name: "not ready nodes filtered",
-			nodes: []*v1.Node{
-				newNodeWithInternalIPOnly("node1", "192.168.1.1", true),
-				newNodeWithInternalIPOnly("node2", "192.168.1.2", false),
-			},
-			expectedReadyCount:    1,
-			expectedFilteredCount: 1,
-		},
 	}
 
 	for _, test := range testcases {

go.mod

@@ -21,7 +21,6 @@ require (
 	k8s.io/client-go v0.35.0
 	k8s.io/cloud-provider v0.35.0
 	k8s.io/component-base v0.35.0
-	k8s.io/component-helpers v0.35.0
 	k8s.io/klog/v2 v2.130.1
 	k8s.io/utils v0.0.0-20260108192941-914a6e750570
 	sigs.k8s.io/controller-runtime v0.22.4
@@ -122,6 +121,7 @@ require (
 	gopkg.in/natefinch/lumberjack.v2 v2.2.1 // indirect
 	k8s.io/apiextensions-apiserver v0.35.0 // indirect
 	k8s.io/apiserver v0.35.0 // indirect
+	k8s.io/component-helpers v0.35.0 // indirect
 	k8s.io/controller-manager v0.35.0 // indirect
 	k8s.io/kms v0.35.0 // indirect
 	k8s.io/kube-openapi v0.0.0-20251125145642-4e65d59e963e // indirect