Replace alpine:3.15 with distroless static#912
Open
thearyanahmed wants to merge 1 commit intomasterfrom
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR hardens the container images for the DigitalOcean cloud-controller-manager and its admission server by switching from an Alpine-based runtime image to a distroless static (nonroot) runtime image.
Changes:
- Replace
alpine:3.15withgcr.io/distroless/static-debian12:nonrootfor both images. - Remove package installation (
apk add ca-certificates) and simplify the image contents to just the compiled binaries. - Use
ENTRYPOINTto run the binaries by default.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cloud-controller-manager/cmd/digitalocean-cloud-controller-manager/Dockerfile | Switch runtime base image to distroless static nonroot; copy binary and set entrypoint. |
| cloud-controller-manager/cmd/digitalocean-cloud-controller-manager-admission-server/Dockerfile | Same distroless static nonroot migration for the admission server image. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR Replaces
alpine:3.15withgcr.io/distroless/static-debian12:nonrootfor both images.Also removes package installation (
apk add ca-certificates) and simplify the image contents to just the compiled binaries.