fix --format and --no-header on gradient commands#1862
Open
m3co-code wants to merge 2 commits into
Open
Conversation
to fix that "--format ID" renders <nil> ID is the standard in go and doctl, it was also advertised on the header summary of the command returns, but in the format would have needed to be selected via Id
DO-rrao
reviewed
Jun 12, 2026
| "github.com/digitalocean/doctl/commands/displayers" | ||
| ) | ||
|
|
||
| func ListRegionsCmd() *Command { |
Contributor
There was a problem hiding this comment.
list-models and list-regions are now registered twice
After this PR, both commands appear duplicated in doctl gradient --help:
Contributor
Author
There was a problem hiding this comment.
Thx @DO-rrao! Good catch. I'll spend a little bit more time on that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains two fixes:
--formatand--no-headerwas ignored ondoctl gradient list-modelsandlist-regions--format IDwas not working on the list, even though the header was advertising ID, Id was expected which is inconsistent with the header and the rest of doctl, hence having moved to ID consistently