[CON-13686] Make HA flag optional in Kubernetes cluster create request for version-based API defaults#970
Open
pyadagiri-do wants to merge 4 commits into
Open
Conversation
| // Create cluster with highly available control plane | ||
| HA bool `json:"ha"` | ||
| // HA enables a highly available control plane. When omitted, the API applies | ||
| // version-based defaults: false for versions <= 1.36, true for versions > 1.36. |
Contributor
There was a problem hiding this comment.
Suggested change
| // version-based defaults: false for versions <= 1.36, true for versions > 1.36. | |
| // version-based defaults: false for versions < 1.36, true for versions >= 1.36. |
We're planning to make this switch with version 1.36 for now, right?
Contributor
There was a problem hiding this comment.
(if so, please correct the UpdateClusterRequest comment as well)
Author
There was a problem hiding this comment.
Updated above comment. No change in behaviour for UpdateClusterRequest for HA
pyadagiri-do
commented
Mar 16, 2026
| // Create cluster with highly available control plane | ||
| HA bool `json:"ha"` | ||
| // HA enables a highly available control plane. When omitted, the API applies | ||
| // version-based defaults: false for versions <= 1.36, true for versions > 1.36. |
Author
There was a problem hiding this comment.
Updated above comment. No change in behaviour for UpdateClusterRequest for HA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes the
HAfield optional (*boolwithomitempty) inKubernetesClusterCreateRequestso the API can apply version-based defaults when omitted:falsetrueChanges
KubernetesClusterCreateRequest.HA:bool→*boolwithomitemptyTestKubernetesClusterCreateRequest_HA_JsonMarshalto verify JSON marshalingJira
https://do-internal.atlassian.net/browse/CON-13686
DO NOT REVIEW - Draft PR for WIP