You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is worker_subnet_uuid immutable after cluster creation? I noticed cluster_update.yml isn't touched, which suggests this can't be changed post-create. If that's intentional, could we call it out in the description on the create side? Similar to how the ha field documents its behavioral constraints. Something like: "This value cannot be changed after the cluster is created."
Should there be a scope requirement note? The sibling vpc_uuid field ends its description with Requires \vpc:read scope.Since subnets are a VPC sub-resource, does setting/readingworker_subnet_uuidalso requirevpc:read(or some other scope)? Worth aligning with thevpc_uuid precedent if so.
Create-request example doesn't demonstrate the new field. The response examples in responses/examples.yml include worker_subnet_uuid, but the curl create example in examples/curl/kubernetes_create_cluster.yml doesn't show a caller actually setting it. Could we add it there so users see how to use the new field end-to-end?
Minor: The description says "Requires vpc_uuid to be set" — is this constraint enforced server-side with a validation error? Just confirming, since the schema itself doesn't express the dependency (no dependentRequired/oneOf).
Otherwise LGTM — examples coverage is complete and the write/read description split follows the existing pattern nicely.
Is worker_subnet_uuid immutable after cluster creation?
Yes, added a callout
Should there be a scope requirement note?
Yes, TY! Required vpc:read, same as vpc_uuid
Create-request example doesn't demonstrate the new field.
Didn't realize that was separate from the response examples tbh. Added the field there.
The description says "Requires vpc_uuid to be set" — is this constraint enforced server-side with a validation error? Just confirming, since the schema itself doesn't express the dependency (no dependentRequired/oneOf).
Yes, there is a validation in the API for this. I tried adding dependentRequired, but apparently it's only available in openapi 3.1 and we're on 3.0. And using "oneOf" to express this seems confusing, no? Not even sure how to express this with oneof tbh. If it's okay to just have a description callout, I'd keep it this way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New field was just added to DOKS API.