Nfs access point apis#1192
Merged
Merged
Conversation
sgupta832
force-pushed
the
nfs-access-point-apis
branch
from
8ea7456 to
e9e6da6
Compare
Align models and examples with sharesvc behavior: fix delete action status, document validation constraints, add access_points to share responses, dedupe the action schema, and wire get/list responses to shared model files. Co-authored-by: Cursor <cursoragent@cursor.com>
sgupta832
force-pushed
the
nfs-access-point-apis
branch
from
e9e6da6 to
25aaaca
Compare
Align the create request model and examples with cthulhu: every non-default access point must be pinned to a VPC at creation time. Co-authored-by: Cursor <cursoragent@cursor.com>
v-amanjain-afk
approved these changes
Jun 24, 2026
DO-rrao
reviewed
Jun 24, 2026
DO-rrao
reviewed
Jun 24, 2026
DO-rrao
reviewed
Jun 24, 2026
| $ref: 'responses/access_point_create.yml' | ||
|
|
||
| '400': | ||
| $ref: 'responses/bad_request.yml' |
Collaborator
There was a problem hiding this comment.
The 400 here points at bad_request.yml, but that one's all about share sizing (size_gib >= 50Gib), which doesn't really fit access point creation. Could we give it its own 400 example (or at least a more generic message)? Otherwise the docs will tell people the wrong thing. Delete has the same issue on its 400.
Contributor
Author
There was a problem hiding this comment.
Replaced share bad_request.yml with access_point_bad_request.yml on create/delete.
DO-rrao
reviewed
Jun 24, 2026
| operationId: nfs_create_access_point | ||
|
|
||
| summary: Create an NFS access point | ||
|
|
Collaborator
There was a problem hiding this comment.
can you pls share response for this endpoint as is?
will help me to review.
Contributor
Author
There was a problem hiding this comment.
Updated create (and list/get/delete) examples to match staging — pls see latest commit.
Use real API response samples, correct action enums (SHARE/IN_PROGRESS), add access-point-specific 400 responses, and add cURL code samples for all four access point operations. Co-authored-by: Cursor <cursoragent@cursor.com>
Use nfs:list for list access points, centralize path params in parameters.yml, enrich nfs_get and nfs_actions examples, and add access-point-specific 400/409 response examples. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds NFS access point CRUD endpoints to the public OpenAPI spec, aligned with the cthulhu sharesvc/publicapi implementation.
POST /v2/nfs/shares/{share_id}/access_points— create access pointGET /v2/nfs/shares/{share_id}/access_points— list access points (optional status filter)GET /v2/nfs/access_points/{access_point_id}— get access pointDELETE /v2/nfs/access_points/{access_point_id}— delete access pointaccess_pointsarray on share GET/LIST responsesGen1 scope: Create, Get, List, Delete only.
UpdateAccessPointPolicyis intentionally omitted (not yet supported in sharesvc).Supersedes #1191 — includes original spec plus review fixes (validation docs, correct delete action status, shared action schema, error responses).
Test plan
make bundlepassesmake lintpasses (0 errors)