Rebase - #1
Open
digitizdat wants to merge 242 commits into
Open
Conversation
Some (if not all) just ignore the response if it's not a 200 and just consider the server borked. Closes #192
The main motive here isn't full Windows support per, but being able to run tests on Windows, as this is my main platform. Booting a VM just to run tests is cumbersome.
Except for changes required to comply to the XSD specification, this does not include any feature this version brings Closes #194
We have int folder ids for long now, this isn't needed anymore
Bare excepts will catch `GeneratorExit` exceptions which are raised whenever a generator stops. This was causing issues when transcoding and caching the results. All instances of bare excepts have been replaced with scoped versions.
Hunting for the last ResourceWarnings
And upgrade code syntax
Service isn't available anymore
- `supysonic-server` now binds to localhost by default instead of all IPv4 interfaces - a bit of cookie configuration - no more open redirect on web UI login
RCE surface was the command serialization. Would have required an attacker to: - get their hands on the authkey (or the database, since it's stored there) - have access to the daemon socket (a Unix socket or Windows pipe by default) With serialization changed, the RCE risk is no more.
Also optimize its queue for large batches while we're are it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.