Skip to content

Commit d505bbd

Browse files
dimakisclaude
andcommitted
fix: address Centaur review findings
- Fix workload broadcast test: use setWorkloadBroadcast() to wire the capture callback into the module-scoped closure instead of patching a nonexistent app property (test was passing vacuously) - Fix design docs table: replace 5 nonexistent doc references with actual filenames (session-isolation-overhaul, counter-proposal, phase2-handoff, task-board-phase1-plan; remove workflow-templates) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 0a33638 commit d505bbd

2 files changed

Lines changed: 8 additions & 8 deletions

File tree

README.md

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -909,11 +909,11 @@ Detailed design documents for major features live in `docs/design/`:
909909
| ---------------------------------------- | ------------------------------------------------- |
910910
| `message-protocol-v2.md` | v2 WebSocket block lifecycle protocol |
911911
| `global-task-board.md` | Task board architecture and state machine |
912+
| `task-board-phase1-plan.md` | Task board phase 1: persistence and tree structure |
912913
| `task-board-phase2-plan.md` | Task board phase 2: orchestration and MCP |
913-
| `task-board-phase3-plan.md` | Task board phase 3: verification and completion |
914-
| `session-isolation-worktrees.md` | Git worktree isolation design |
915-
| `session-isolation-enforcement.md` | Worktree guard enforcement strategy |
916-
| `session-isolation-multi-repo.md` | Multi-repo worktree support |
914+
| `session-isolation-overhaul.md` | Session isolation architecture overhaul |
915+
| `session-isolation-counter-proposal.md` | Alternative session isolation design |
916+
| `session-isolation-phase2-handoff.md` | Session isolation phase 2 handoff notes |
917917
| `session-state-machine.md` | Session lifecycle state transitions |
918918
| `skills-system-v1-plan.md` | Skills system architecture |
919919
| `voice-integration.md` | Voice I/O (STT + TTS) design |
@@ -925,7 +925,6 @@ Detailed design documents for major features live in `docs/design/`:
925925
| `token-visibility.md` | Token usage visibility in the UI |
926926
| `boot-context-pill-ux-fixes.md` | Boot context UX improvements |
927927
| `phase-a-test-harness.md` | Test harness architecture |
928-
| `workflow-templates.md` | Workflow template system |
929928

930929
Additional docs:
931930
- [docs/onboarding.md](docs/onboarding.md) — Setup and configuration walkthrough

server/__tests__/workload-routes.test.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -546,9 +546,9 @@ describe('workload routes', () => {
546546
});
547547

548548
it('POST /api/workload/items/:id/promote — fallback does not broadcast workload update', async () => {
549+
const { setWorkloadBroadcast } = await import('../app.js');
549550
const broadcasts: unknown[] = [];
550-
const origBroadcast = (app as any)._workloadBroadcast;
551-
(app as any)._workloadBroadcast = (msg: unknown) => broadcasts.push(msg);
551+
setWorkloadBroadcast((msg: Record<string, unknown>) => broadcasts.push(msg));
552552

553553
await request(app)
554554
.post('/api/workload/items/telos-no-broadcast/promote')
@@ -558,7 +558,8 @@ describe('workload routes', () => {
558558
const workloadBroadcasts = broadcasts.filter((b: any) => b.type === 'workload_item_updated');
559559
expect(workloadBroadcasts).toHaveLength(0);
560560

561-
(app as any)._workloadBroadcast = origBroadcast;
561+
// Restore to null to avoid leaking into other tests
562+
setWorkloadBroadcast((() => {}) as any);
562563
});
563564

564565
it('POST /api/workload/items/:id/promote — broadcasts workload_item_updated', async () => {

0 commit comments

Comments
 (0)