Skip to content

Commit 082491f

Browse files
fix: Remove unused enable_python_native_blobs setting
This setting was defined but never read by any code - dead code. Removed from: - Config class definition - Template generation - Test that used it (test still validates error suppression) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
1 parent fa1eb65 commit 082491f

File tree

3 files changed

+2
-7
lines changed

3 files changed

+2
-7
lines changed

docs/design/thread-safe-mode.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,6 @@ All settings become connection-scoped and are accessed via `conn.config` (read/w
5858
| `display_width` | int | 14 | Column width for display |
5959
| `show_tuple_count` | bool | True | Show tuple count in repr |
6060
| `loglevel` | str | "INFO" | Logging level |
61-
| `enable_python_native_blobs` | bool | True | Use Python-native blob serialization |
6261
| `filepath_checksum_size_limit` | int | None | Max file size for checksum |
6362

6463
Connection parameters (set at creation, read-only after):
@@ -428,7 +427,6 @@ class ConnectionConfig:
428427
"display_width": 14,
429428
"show_tuple_count": True,
430429
"loglevel": "INFO",
431-
"enable_python_native_blobs": True,
432430
"filepath_checksum_size_limit": None,
433431
}
434432

src/datajoint/settings.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -347,7 +347,6 @@ class Config(BaseSettings):
347347
description="Thread-safe mode. When True, global config access is blocked. "
348348
"Once enabled, cannot be disabled. Use Connection.from_config() instead.",
349349
)
350-
enable_python_native_blobs: bool = True
351350
filepath_checksum_size_limit: int | None = None
352351

353352
# Cache paths
@@ -850,7 +849,6 @@ def save_template(
850849
},
851850
"loglevel": "INFO",
852851
"safemode": True,
853-
"enable_python_native_blobs": True,
854852
"cache": None,
855853
"query_cache": None,
856854
"download_path": ".",

tests/integration/test_jobs.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -108,10 +108,9 @@ def test_sigterm(clean_jobs, schema_any):
108108

109109

110110
def test_suppress_dj_errors(clean_jobs, schema_any):
111-
"""Test that DataJoint errors are suppressible without native py blobs."""
111+
"""Test that DataJoint errors are suppressible."""
112112
error_class = schema.ErrorClass()
113-
with dj.config.override(enable_python_native_blobs=False):
114-
error_class.populate(reserve_jobs=True, suppress_errors=True)
113+
error_class.populate(reserve_jobs=True, suppress_errors=True)
115114
assert len(schema.DjExceptionName()) == len(error_class.jobs.errors) > 0
116115

117116

0 commit comments

Comments
 (0)