Add Dynamo search bar debounce#2
Open
bendikberg wants to merge 194 commits into
Open
Conversation
…namoDS#15444) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: pinzart90 <tiberiu.pinzariu@gmail.com>
…S#15747) Co-authored-by: ZbynekHanak-RWS <118838661+ZbynekHanak-RWS@users.noreply.github.com> Co-authored-by: cBuild <smb_p_escbuild@autodesk.com> Co-authored-by: Roberto T <61755417+RobertGlobant20@users.noreply.github.com>
pinzart90
pushed a commit
that referenced
this pull request
Feb 10, 2025
dimven-adsk
pushed a commit
that referenced
this pull request
May 9, 2025
dimven-adsk
pushed a commit
that referenced
this pull request
May 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The Dynamo search bar feels stuttery when typing many characters in succession, as every key stroke starts a new search. These searches then block the Dynamo UI and will in some cases leave the UI hanging for multiple seconds at a time while all the searches complete. Since the user most likely didn't want to search for 'e', 'el', 'ele', ... etc. when they typed 'element', this both breaks user flow and leads to search feeling way slower than it has to be.
This change adds a debounce to the search (which could potentially be configurable by the user), which postpones the search until the user has paused typing for a short while.
Current search
xSuE3gCjMb.mp4
Proposed change
mfDyPu2TBW.mp4
Declarations
Check these if you believe they are true
*.resxfilesReviewers
FYIs