Skip to content

Make the PROMPT_COMMAND chain with existing#157

Open
aJanuary wants to merge 1 commit into
diogocavilha:masterfrom
aJanuary:play-well-with-others
Open

Make the PROMPT_COMMAND chain with existing#157
aJanuary wants to merge 1 commit into
diogocavilha:masterfrom
aJanuary:play-well-with-others

Conversation

@aJanuary
Copy link
Copy Markdown

If something else has already set the PROMPT_COMMAND (for example, ghostty or mise), currently the themes will clobber the existing value, breaking their functionality.

This patch adds ;$PROMPT_COMMAND to the end, so that bash will execute the existing commands as well.

@diogocavilha
Copy link
Copy Markdown
Owner

Hi, @aJanuary.

You've made a good work here! Thank you so much for your contribution.
I'll be testing it asap, so I can release a new version of it.

I'd ask you just to change de version.sh file and the CHANGELOG.md according to the CONTRIBUTING.md

If something else has already set the PROMPT_COMMAND (for example,
ghostty or mise), currently the themes will clobber the existing value,
breaking their functionality.

This patch adds `;$PROMPT_COMMAND` to the end, so that bash will execute
the existing commands as well.
@aJanuary aJanuary force-pushed the play-well-with-others branch from 985e590 to 7c29d10 Compare October 31, 2025 10:19
@aJanuary
Copy link
Copy Markdown
Author

@diogocavilha I have updated the version.sh and CHANGELOG.md files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants