Types: Member::$roles

[liamduckett]

Environment

• PHP Version:
  • 8.4
• DiscordPHP Version:
  • 10.29.6

Description
My static analyser (PHPStan) fails with the following code:

$member->roles->any(fn() => true)

Cannot call method any() on 
array<Discord\Parts\Guild\Role>|(Discord\Helpers\ExCollectionInterface&iterable<Discord\Parts\Guild\Role>).
🪪  method.nonObject

Expected behavior
No error - this method can only return ExCollectionInterface&iterable<Role> so the call to any is type safe.

Additional context
There was mention of the proposed fix (removing the impossible type) causing issues with most IDEs and even intelliphense. See: #1430.

[valzargaming]

This should be fixed in e3a1490. It was the only case where I noticed the return type wasn't quite complete.

[liamduckett]

I don't believe it is - I tested in my codebase on v10.40.18 with no luck. I wouldn't have expected it to though, as that change doesn't remove the array type?

It also may be worth noting that static analysis (or at least PHPStan) won't look at the docblock on getRolesAttribute when determining the type of $member->roles - it'll use the @property docblock declared at the class level.

Any chance you can share what the IDE / intelliphense issues are?

[valzargaming]

🤷

[liamduckett]

I'm unable to see an issue with my proposed change in VSCode (1.105.1) - using the latest version of PHP Intelephense (
1.15.0) - is this what was being used in the above screenshot?

When I narrow the typehint on $roles to just ExCollectionInterface<Role> I get the following:

This suggests to me that it can infer the ArrayAcess (as it should). Is there any additional information you can provide?

Appreciate your continued time into this!