Skip to content

Reaction class should use Emoji Part rather than stdClass #1422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
valzargaming wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Reaction class should use Emoji Part rather than stdClass #1422

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
83acf54
Update Reaction.php
valzargaming Oct 15, 2025
e547815
Update Reaction.php
valzargaming Oct 20, 2025
7017b19
Update Reaction.php
valzargaming Apr 27, 2026
7a1eefc
Set guild id
valzargaming Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/Discord/Parts/Channel/Reaction.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
use Discord\Parts\Thread\Thread;
use Discord\Parts\User\User;
use React\Promise\PromiseInterface;
use stdClass;
use Symfony\Component\OptionsResolver\OptionsResolver;

use function Discord\normalizePartId;
Expand Down Expand Up @@ -104,8 +103,8 @@ public function fetch(): PromiseInterface
*/
protected function setIdAttribute(string $value): void
{
if (! isset($this->attributes['emoji'])) {
$this->attributes['emoji'] = new stdClass();
if ($this->emoji === null) {
$this->attributes['emoji'] = $this->factory->part(Emoji::class, [], true);
Copy link

Copilot AI Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the reaction has no existing emoji attribute, this initializes an Emoji Part with an empty payload. Because getEmojiAttribute() only injects guild_id via attributePartHelper() when converting non-Emoji data, an already-instantiated Emoji will not get guild_id populated, which can break Emoji behavior that relies on guild context (e.g., Emoji::guild, roles resolution). Consider initializing the Emoji Part with ['guild_id' => $this->guild_id] (or otherwise ensuring guild_id is set) when creating it here.

Suggested change
$this->attributes['emoji'] = $this->factory->part(Emoji::class, [], true);
$this->attributes['emoji'] = $this->factory->part(Emoji::class, ['guild_id' => $this->guild_id], true);

Copilot uses AI. Check for mistakes.
}

$colonDelimiter = explode(':', $value);
Expand Down