Components v2#7487
Merged
Merged
Conversation
anthonydiscord
requested review from
colinloretz and
markmandel
and removed request for
a team and
markmandel
Lulalaby
reviewed
Apr 22, 2025
Lulalaby
reviewed
Apr 22, 2025
Contributor
There was a problem hiding this comment.
The following message is repeated really often:
> info
> To use this component, you need to send the [message flag](/docs/resources/message#message-object-message-flags) `1 << 15` (IS_COMPONENTS_V2) which can be activated on a per-message basis.
Might it be better to just specify a version number in the heading, linking to "this needs flag xy"?
Anyways, I really love how the docs turned out. Might've overseen something. Will look a bit later again.
The suggestions should catch most > info parts and change them to :::info as Justin mentioned.
Also discussion point: Putting IS_COMPONENTS_V2 into ` IS_COMPONENTS_V2
Since I was asked to review
Comment on lines
+52
to
+56
| | 13 | [File](/docs/components/reference#file) | Displays an attached file | Content | Message | | ||
| | 14 | [Separator](/docs/components/reference#separator) | Component to add vertical padding between other components | Layout | Message | | ||
| | 17 | [Container](/docs/components/reference#container) | Container that visually groups a set of components | Layout | Message | |
Contributor
There was a problem hiding this comment.
I assume we decided against including the content inventory type (it can be received) as reference?
advaith1
reviewed
Apr 22, 2025
Icebluewolf
reviewed
Apr 22, 2025
Icebluewolf
left a comment
Icebluewolf
left a comment
There was a problem hiding this comment.
Just wanted to point out a few things I saw :)
Sorry, if these are overly nit-picky.
Lulalaby
reviewed
Apr 22, 2025
Contributor
Lulalaby
left a comment
Lulalaby
left a comment
There was a problem hiding this comment.
Additionally, since it came up again on our lib server: It should be mentioned that components (namely text display) can mention users and roles.
Lulalaby
reviewed
Apr 22, 2025
This was referenced Apr 22, 2025
wasdennnoch
reviewed
Apr 22, 2025
wasdennnoch
reviewed
Apr 22, 2025
davfsa
reviewed
Apr 22, 2025
wasdennnoch
reviewed
Apr 22, 2025
6 tasks
8 tasks
6 tasks
anthonydiscord
force-pushed
the
components-v2
branch
2 times, most recently
from
07ceead to
51517d4
Compare
anthonydiscord
force-pushed
the
components-v2
branch
from
f5c4486 to
17d4a35
Compare
JustinBeckwith
approved these changes
Apr 22, 2025
Contributor
JustinBeckwith
left a comment
JustinBeckwith
left a comment
There was a problem hiding this comment.
"just let me sneak one more merge conflict in first"
Contributor
|
dammit it too late |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding documentation, changelog, and links updates for components v2. The interactions.js library and samples using it are going to follow in another PR.