-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Document RPC over IPC #8246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+101
−46
Merged
Document RPC over IPC #8246
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
32fbc7a
feat: Information about RPC over IPC
5XS c8073bd
fix: accordion
5XS ed357a1
fix: wrong placed spaces in table
5XS 143ab33
unwanted lines removal
5XS 8c708de
return back links
5XS 240510f
return links for rpc commands
5XS File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any particular reason to remove all the anchor links? I don't have super strong opinions on this, but they seem handy to have.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
advaith1 said to remove them since they led to nowhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aaand it was before you changed the structure. So I can probably return it (or maybe I misunderstood something)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ones that don't have references to link to - definitely remove, but we could keep the ones that do point to existing links.
https://docs.discord.com/developers/topics/rpc#getchannels works for example (drops a little low, but better than not having) - so I'd advocate for putthing this back in -- they are handy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
heh, yeah there was that too 😁
All good, easy enough to diff and put it back.