use rngh v2 api, refactor scrollable animated ref & gesture interaction w/ scrollEnabled#18
Draft
yayvery wants to merge 6 commits intodiscord-fork-4.6.1from
Draft
use rngh v2 api, refactor scrollable animated ref & gesture interaction w/ scrollEnabled#18yayvery wants to merge 6 commits intodiscord-fork-4.6.1from
yayvery wants to merge 6 commits intodiscord-fork-4.6.1from
Conversation
* chore: updated dependencies * feat: rewrite the gesture api with gh2 gorhom@6a4d296 fix(gorhom#1119): fixed race condition between onmount and keyboard animations
fix: crash on swipe down (gorhom#1367)
gorhom#1674) fix: bottom sheet not appearing for users that have reduced motion turned on (gorhom#1743)(by @fobos531)
yayvery
force-pushed
the
discord-fork-4.6.1-rngh-v2
branch
from
8515fdb to
69b8346
Compare
yayvery
force-pushed
the
discord-fork-4.6.1-rngh-v2
branch
5 times, most recently
from
56c3c78 to
2ec2604
Compare
yayvery
changed the title
yayvery
force-pushed
the
discord-fork-4.6.1-rngh-v2
branch
3 times, most recently
from
f1f41b2 to
ed0359c
Compare
yayvery
changed the title
yayvery
changed the title
yayvery
changed the title
yayvery
force-pushed
the
discord-fork-4.6.1-rngh-v2
branch
8 times, most recently
from
c82d5b8 to
9fd7242
Compare
remove preserveScrollMomentum + scrollBuffer + lockableScrollableContentOffsetY props we're using `preserveScrollMomentum` in the media picker, but i'm removing it because i feel the behavior is actually detrimental to the UX, and to simplify the refactor to scrollEnabled in the next commit. `lockableScrollableContentOffsetY` is removed since it won't be necessary after the scrollEnabled refactor `scrollBuffer` was no longer used. removed custom gesture/scroll handling hooks after refactoring to use scrollEnabled, we can add other props to add custom behaviors if needed. refactored scroll/pan gesture interaction based on software-mansion/react-native-gesture-handler#420 (comment) and approach from rngh example https://github.com/software-mansion/react-native-gesture-handler/blob/main/example/src/new_api/bottom_sheet/index.tsx#L87 scrollEnabled inspired by react-native-swipe-modal https://github.com/birdwingo/react-native-swipe-modal
yayvery
force-pushed
the
discord-fork-4.6.1-rngh-v2
branch
from
9fd7242 to
df1cc1c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
preserveScrollMomentumin the media picker, but i'm removing it because i feel the behavior is actually detrimental to the UX, and to simplify the refactor to scrollEnabled.lockableScrollableContentOffsetYis removed since it won't be necessary after the scrollEnabled refactorscrollBufferwas no longer used.