test: use defineProperty to enforce mock theme settings in acceptance test

Author: akanora

test/javascripts/acceptance/nav-bar-additions-test.js

@@ -5,15 +5,13 @@ import { test } from "qunit";
 acceptance("Custom Top Navigation Links | Topic Counts", function (needs) {
   needs.user();
 
-  let originalNavLinks;
-  let originalShowCounts;
+  let originalSettings;
 
   needs.hooks.beforeEach(() => {
-    if (window.settings) {
-      originalNavLinks = window.settings.nav_links;
-      originalShowCounts = window.settings.Show_counts;
+    originalSettings = window.settings;
 
-      window.settings.nav_links = [
+    const mockSettings = {
+      nav_links: [
         {
           display_name: "New Topics",
           title: "new topics",
@@ -24,15 +22,29 @@ acceptance("Custom Top Navigation Links | Topic Counts", function (needs) {
           title: "unread topics",
           url: "/unread",
         },
-      ];
-      window.settings.Show_counts = true;
-    }
+      ],
+      Show_counts: true,
+    };
+
+    // Use defineProperty to ensure window.settings returns our mock settings
+    // regardless of when or how the framework boots/initializes it.
+    Object.defineProperty(window, "settings", {
+      configurable: true,
+      enumerable: true,
+      get() {
+        return mockSettings;
+      },
+      set() {
+        // Prevent framework from overwriting our mock settings during boot
+      },
+    });
   });
 
   needs.hooks.afterEach(() => {
-    if (window.settings) {
-      window.settings.nav_links = originalNavLinks;
-      window.settings.Show_counts = originalShowCounts;
+    // Restore original window.settings
+    delete window.settings;
+    if (originalSettings) {
+      window.settings = originalSettings;
     }
   });
 
@@ -45,6 +57,13 @@ acceptance("Custom Top Navigation Links | Topic Counts", function (needs) {
 
     await visit("/latest");
 
+    // Print navigation HTML to debug
+    // eslint-disable-next-line no-console
+    console.log(
+      "NAVIGATION BAR HTML:",
+      document.querySelector(".nav-pills")?.innerHTML || "NOT FOUND"
+    );
+
     assert.ok(
       exists(".nav-item_custom_new-topics"),
       "custom navigation item for new topics is rendered"