test: use defineProperty to enforce mock theme settings in acceptance test

Author: akanora

test/javascripts/acceptance/nav-bar-additions-test.js

@@ -4,20 +4,48 @@ import { test } from "qunit";
 
 acceptance("Custom Top Navigation Links | Topic Counts", function (needs) {
   needs.user();
-  needs.settings({
-    nav_links: [
-      {
-        display_name: "New Topics",
-        title: "new topics",
-        url: "/new",
+
+  let originalSettings;
+
+  needs.hooks.beforeEach(() => {
+    originalSettings = window.settings;
+
+    const mockSettings = {
+      nav_links: [
+        {
+          display_name: "New Topics",
+          title: "new topics",
+          url: "/new",
+        },
+        {
+          display_name: "Unread Topics",
+          title: "unread topics",
+          url: "/unread",
+        },
+      ],
+      Show_counts: true,
+    };
+
+    // Use defineProperty to ensure window.settings returns our mock settings
+    // regardless of when or how the framework boots/initializes it.
+    Object.defineProperty(window, "settings", {
+      configurable: true,
+      enumerable: true,
+      get() {
+        return mockSettings;
       },
-      {
-        display_name: "Unread Topics",
-        title: "unread topics",
-        url: "/unread",
+      set() {
+        // Prevent framework from overwriting our mock settings during boot
       },
-    ],
-    Show_counts: true,
+    });
+  });
+
+  needs.hooks.afterEach(() => {
+    // Restore original window.settings
+    delete window.settings;
+    if (originalSettings) {
+      window.settings = originalSettings;
+    }
   });
 
   test("shows new and unread counts in navigation items", async function (assert) {
@@ -27,7 +55,14 @@ acceptance("Custom Top Navigation Links | Topic Counts", function (needs) {
     topicTrackingState.countNew = () => 42;
     topicTrackingState.countUnread = () => 17;
 
-    await visit("/");
+    await visit("/latest");
+
+    // Print navigation HTML to debug
+    // eslint-disable-next-line no-console
+    console.log(
+      "NAVIGATION BAR HTML:",
+      document.querySelector(".nav-pills")?.innerHTML || "NOT FOUND"
+    );
 
     assert.ok(
       exists(".nav-item_custom_new-topics"),