feat: add locale dropdown selector for nav link translations

Author: akanora

javascripts/discourse/initializers/init-nav-bar-additions.js

@@ -1,44 +1,24 @@
 import { withPluginApi } from "discourse/lib/plugin-api";
-import { i18n } from "discourse-i18n";
-import { themePrefix } from "virtual:theme";
+import I18n from "I18n";
 
 /**
- * Resolve a localized field for a nav link.
- *
- * Priority:
- * 1. Theme translations (locales/*.yml via i18n/themePrefix) — for default
- *    links that have keys defined in locale files.
- * 2. Settings translations (nested translations objects) — for custom links
- *    where admins add per-locale overrides inside the settings editor.
- * 3. Raw settings value — the base display_name/title from the link.
+ * Resolve a field value from a nav link, checking for a locale-specific
+ * translation first. Falls back to the base field value.
  */
 function getLocalizedField(link, fieldName) {
-  // 1. Try theme translations (locale files)
-  const key = link.display_name.replace(/\s+/g, "_").toLowerCase();
-  const translationKey = themePrefix(`nav_links.${key}.${fieldName}`);
-  const themeTranslated = i18n(translationKey);
-
-  if (themeTranslated !== translationKey) {
-    return themeTranslated;
-  }
-
-  // 2. Try settings translations (nested objects)
   const translations = link.translations;
-  if (translations && translations.length > 0) {
-    const locale = i18n.currentLocale?.() || i18n.locale || "";
+  if (!translations || translations.length === 0) {
+    return link[fieldName];
+  }
 
-    // Exact match first (e.g. "pt_BR"), then prefix match (e.g. "pt")
-    const match =
-      translations.find((t) => t.locale === locale) ||
-      translations.find((t) => locale.startsWith(t.locale));
+  const locale = I18n.currentLocale();
 
-    if (match && match[fieldName]) {
-      return match[fieldName];
-    }
-  }
+  // Try exact match first (e.g. "pt_BR"), then prefix match (e.g. "pt")
+  const match =
+    translations.find((t) => t.locale === locale) ||
+    translations.find((t) => locale.startsWith(t.locale));
 
-  // 3. Fallback to raw settings value
-  return link[fieldName];
+  return (match && match[fieldName]) || link[fieldName];
 }
 
 // Built-in Discourse filter routes that have associated topic counts

locales/en.yml

@@ -19,21 +19,11 @@ en:
               description: Per-language overrides for display name and title
               properties:
                 locale:
-                  label: Language code
-                  description: "Locale code (e.g. fr, de, zh_CN, pt_BR)"
+                  label: Language
+                  description: Select the language for this translation
                 display_name:
                   label: Display name
                   description: Translated display name for this language
                 title:
                   label: Title
                   description: Translated title (hover text) for this language
-  nav_links:
-    latest:
-      display_name: Latest
-      title: topics with recent posts
-    categories:
-      display_name: Categories
-      title: all topics grouped by category
-    top:
-      display_name: Top
-      title: the most active topics in the last year, month, week or day

settings.yml

@@ -39,11 +39,58 @@ nav_links:
           identifier: locale
           properties:
             locale:
-              type: string
+              type: enum
               required: true
-              validations:
-                min_length: 2
-                max_length: 10
+              choices:
+                - ar
+                - be
+                - bg
+                - bs_BA
+                - ca
+                - cs
+                - da
+                - de
+                - el
+                - en
+                - en_GB
+                - es
+                - et
+                - fa_IR
+                - fi
+                - fr
+                - gl
+                - he
+                - hr
+                - hu
+                - hy
+                - id
+                - it
+                - ja
+                - ko
+                - lt
+                - lv
+                - nb_NO
+                - nl
+                - pl_PL
+                - pt
+                - pt_BR
+                - ro
+                - ru
+                - sk
+                - sl
+                - sq
+                - sr
+                - sv
+                - sw
+                - te
+                - th
+                - tr_TR
+                - ug
+                - uk
+                - ur
+                - vi
+                - zh_CN
+                - zh_TW
             display_name:
               type: string
               validations: