Fix SQL injection in config setting updates#141
Open
ajfroelich wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes unsafe SQL construction in ConfigDatabase::updateConfigSetting().
The config table name is now restricted to the supported configweb and configdiskover tables. The config name and JSON encoded value now use SQLite prepared statement bindings instead of being placed directly into the SQL query.
I also added a regression test that confirms normal config updates still work and that SQL injected through a configuration name or value cannot modify the users table.
Validation completed successfully with the new security test and PHP syntax checks.