Skip to content

backfill siteUrl #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
disnet merged 1 commit into from
Jun 15, 2026
Merged

backfill siteUrl #301

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 18 additions & 8 deletions frontend/src/lib/services/feedFetcher.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,15 +203,25 @@ export async function fetchAllFeeds(
continue;
}

// Update subscription title/siteUrl from feed metadata (initial pass only)
if (countStatus && feedResult.title) {
// Update subscription title/siteUrl from feed metadata (initial pass only).
// Title and siteUrl are backfilled independently: a sub added before
// siteUrl tracking existed already has its proper title, so gating the
// siteUrl write on a title change would leave it siteUrl-less forever —
// which hides it from cross-type duplicate detection (findCrossTypeDuplicates).
if (countStatus) {
const sub = liveDb.getSubscriptionById(req.subscriptionId);
if (sub && shouldUpdateTitle(sub.title, sub.feedUrl, feedResult.title)) {
await liveDb.updateSubscription(req.subscriptionId, {
title: feedResult.title,
siteUrl: feedResult.siteUrl ?? sub.siteUrl,
localUpdatedAt: Date.now(),
});
if (sub) {
const updates: { title?: string; siteUrl?: string; localUpdatedAt?: number } = {};
if (feedResult.title && shouldUpdateTitle(sub.title, sub.feedUrl, feedResult.title)) {
updates.title = feedResult.title;
}
if (feedResult.siteUrl && feedResult.siteUrl !== sub.siteUrl) {
updates.siteUrl = feedResult.siteUrl;
}
if (updates.title !== undefined || updates.siteUrl !== undefined) {
updates.localUpdatedAt = Date.now();
await liveDb.updateSubscription(req.subscriptionId, updates);
}
}
}

Expand Down
Loading