optimize saved content refresh#312
Merged
Merged
Conversation
The keyset index from migration 0058 changes the implicit row order of backfillUrlNormalized's unordered SELECT, so a different one of two same-URL duplicate saves gets keyed. exportNativeSaves then processed the still-null duplicate first and its UPDATE collided with the already-keyed row on the unique (user_did, url_normalized) index, failing backing-enable.spec.ts. - Make the export's url_normalized UPDATE collision-safe (NOT EXISTS guard), matching the documented intent of backfillUrlNormalized; the loop's alreadyBacked guard still collapses the duplicate to a single member. - Order backfillUrlNormalized's SELECT by id so which duplicate gets keyed is deterministic instead of depending on the query planner's index choice. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.