48k ram patch 1 (#87)

* Add examples of using percent and byte thresholds

* Don't warn experimental on old perl versions

The 'no warnings' experimental for smartmatch is only needed on older perl versions. Otherwise it causes issues.

* Note use of comma in space thresholds

Add note indicating that multiple space thresholds (e.g., % and *B) should be separated with a comma.

* Fix typo in help text

Remove extra 'n' in clusternode_health. Thanks bb-Ricardo

Author: 48kRAM

README.md

@@ -55,6 +55,11 @@ Copy `check_netapp_ontap.pl` script to your nagios libexec folder and configure
 
 Check the space and inode health of a vServer volume on a NetApp Ontap cluster. If space % and space in *B are both defined the smaller value of the two will be used when deciding if the volume is in a warning or critical state. This allows you to accomodate large volume monitoring better. thresh: space % used, space in *B (i.e MB) remaining, inode count remaining, inode % used (Usage example: 80%i), “offline” keyword node: The node option restricts this check by vserver name.
 
+* Examples
+  * `-w 80%` - Warn if volume grows more than 80% full
+  * `-w 100GB` - Warn if volume has less than 100GB free space
+  * `-w 80%,50GB` - Warn if volume is more than 80% used *and* has less than 50GB free space
+
 **aggregate_health**
 
 Check the space and inode health of a cluster aggregate on a NetApp Ontap cluster. If space % and space in *B are both defined the smaller value of the two will be used when deciding if the volume is in a warning or critical state. This allows you to better accomodate large aggregate monitoring. thresh: space % used, space in *B (i.e MB) remaining, inode count remaining, inode % used (Usage example: 80%i), “offline” keyword, “is-home” keyword node: The node option restricts this check by cluster-node name.

check_netapp_ontap.pl

@@ -24,8 +24,8 @@
 use Getopt::Long;
 use POSIX;
 
-# do not show smartmatch warnings
-no warnings 'experimental::smartmatch';
+# do not show smartmatch warnings on older perl versions
+no if $] >= 5.017011, warnings => 'experimental::smartmatch';
 
 my $verbose = undef;
 my $debug = undef;
@@ -1898,17 +1898,17 @@ sub help {
 
 ===OPTION LIST===
 volume_health
-	desc: Check the space and inode health of a vServer volume. If space % and space in *B are both defined the smaller value of the two will be used when deciding if the volume is in a warning or critical state. This allows you to better accomodate large volume monitoring.
+	desc: Check the space and inode health of a vServer volume. If space % and space in *B are both defined the smaller value of the two will be used when deciding if the volume is in a warning or critical state. This allows you to better accomodate large volume monitoring. Separate values with comma.
 	thresh: Space % used, space in *B (i.e MB) remaining, inode count remaining, inode % used (Usage example: 80%i), "offline" keyword.
 	node: The node option restricts this check by vserver name.
 
 aggregate_health
-	desc: Check the space and inode health of a cluster aggregate. If space % and space in *B are both defined the smaller value of the two will be used when deciding if the volume is in a warning or critical state. This allows you to better accomodate large aggregate monitoring.
+	desc: Check the space and inode health of a cluster aggregate. If space % and space in *B are both defined the smaller value of the two will be used when deciding if the volume is in a warning or critical state. This allows you to better accomodate large aggregate monitoring. Separate values with comma.
 	thresh: Space % used, space in *B (i.e MB) remaining, inode count remaining, inode % used (Usage example: 80%i), "offline" keyword, "is-home" keyword.
 	node: The node option restricts this check by cluster-node name.
 
 snapshot_health
-	desc: Check the space and inode health of a vServer snapshot. If space % and space in *B are both defined the smaller value of the two will be used when deciding if the volume is in a warning or critical state. This allows you to better accomodate large snapshot monitoring.
+	desc: Check the space and inode health of a vServer snapshot. If space % and space in *B are both defined the smaller value of the two will be used when deciding if the volume is in a warning or critical state. This allows you to better accomodate large snapshot monitoring. Separate values with comma.
 	thresh: Space % used, space in *B (i.e MB) remaining, inode count remaining, inode % used (Usage example: 80%i), "offline" keyword.
 	node: The node option restricts this check by vserver name.
 
@@ -1954,7 +1954,7 @@ sub help {
 	thresh: N/A not customizable.
 	node: The node option restricts this check by cluster-node name.
 
-clusternnode_health
+clusternode_health
 	desc: Check the cluster-nodes for unhealthy conditions
 	thresh: N/A not customizable.
 	node: The node option restricts this check by cluster-node name.