Skip to content

Commit f17da75

Browse files
committed
Handling unknown fields in s3 event notifications
Signed-off-by: Divyansh Bokadia <dbokadia@amazon.com>
1 parent 6e74852 commit f17da75

2 files changed

Lines changed: 3 additions & 1 deletion

File tree

data-prepper-plugins/s3-source/src/main/java/org/opensearch/dataprepper/plugins/source/s3/S3EventNotification.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77

88
import com.fasterxml.jackson.annotation.JsonCreator;
99
import com.fasterxml.jackson.annotation.JsonIgnore;
10+
import com.fasterxml.jackson.annotation.JsonIgnoreProperties;
1011
import com.fasterxml.jackson.annotation.JsonProperty;
1112
import com.fasterxml.jackson.databind.annotation.JsonSerialize;
1213
import org.joda.time.DateTime;
@@ -84,6 +85,7 @@ public String getArn() {
8485
}
8586
}
8687

88+
@JsonIgnoreProperties(ignoreUnknown = true)
8789
public static class S3ObjectEntity {
8890

8991
private final String key;

data-prepper-plugins/s3-source/src/test/java/org/opensearch/dataprepper/plugins/source/s3/parser/S3EventNotificationParserTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ public class S3EventNotificationParserTest {
2323
"\"responseElements\":{\"x-amz-request-id\":\"xyz\",\"x-amz-id-2\":\"xyz\"},\"s3\":{\"s3SchemaVersion\":\"1.0\"," +
2424
"\"configurationId\":\"xyz\",\"bucket\":{\"name\":\"my-bucket\",\"ownerIdentity\":{\"principalId\":\"ABC\"}," +
2525
"\"arn\":\"arn:aws:s3:::my-bucket\"},\"object\":{\"key\":\"path/to/myfile.log.gz\",\"size\":3159112,\"eTag\":\"abcd123\"," +
26-
"\"sequencer\":\"000\"}}}]}";
26+
"\"sequencer\":\"000\",\"hasObjectAnnotation\":false}}}]}";
2727

2828
public static final String SNS_BASED_MESSAGE = "{\n" +
2929
" \"Type\" : \"Notification\",\n" +

0 commit comments

Comments
 (0)