Fix for exception-unhandled "forked" Promise chain#2101
Merged
Conversation
Co-authored-by: Tim Schilling <schilling711@gmail.com>
Contributor
Author
|
I don't find splitting hairs on wording useful, but so be it. |
tim-schilling
approved these changes
Mar 10, 2025
tim-schilling
left a comment
tim-schilling
left a comment
Member
There was a problem hiding this comment.
This looks reasonable to me. If someone else can pull it down and confirm it works, we can release it. I'll have time later this week otherwise.
Contributor
Author
|
Does it count when I say this change fixed my original problem outlined? After all, I was the OG PR creator. |
Member
|
I've tested it locally and what worked before still seems to work fine. Will do more tests later. The reason provided in the other PR why writing tests is hard makes sense to me and the comment in the code is sufficient to hopefully be aware of this issue when we have to change the code again in the future, for whatever reason. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #2100
I took the liberty of reformatting a bit of code here, I'm sure the autoformatter will have its way with it.