Fix #2292: Gracefully handle SQLParseError in SQL formatting#2322
Closed
okiemute04 wants to merge 2 commits intodjango-commons:mainfrom
Closed
Fix #2292: Gracefully handle SQLParseError in SQL formatting#2322okiemute04 wants to merge 2 commits intodjango-commons:mainfrom
okiemute04 wants to merge 2 commits intodjango-commons:mainfrom
Conversation
…tting - Added try/except blocks around parse_sql calls - Catch SQLParseError and RecursionError - Return error message with original SQL when formatting fails - Added tests for large IN clauses (5000 items) - Prevents SQL panel crashes and freezes with large queries
for more information, see https://pre-commit.ci
Member
|
There is a change addressing this in #2291 already. |
Author
|
Thanks @tim-schilling for the heads up! I see that #2291 already addresses this issue. I'll close this PR. Appreciate you letting me know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds graceful error handling to SQL formatting when queries contain large IN clauses (5000+ items).
When formatting SQL queries with huge IN clauses:
SQLParseError→ SQL panel crashes with 500 errorThe solution wraps
parse_sql()calls in try/except blocks, catchesSQLParseErrorandRecursionError, and returns a user-friendly message with the original SQL when formatting fails.Fixes #2292
Checklist:
docs/changes.rst.AI/LLM Usage